From: Eli Zaretskii <eliz@gnu.org>
To: "Alexandra Hájková" <ahajkova@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v4] gdb: Add source-tracking breakpoints feature
Date: Thu, 30 Apr 2026 11:38:20 +0300 [thread overview]
Message-ID: <861pfw4zcz.fsf@gnu.org> (raw)
In-Reply-To: <20260430075218.6278-1-ahajkova@redhat.com> (message from Alexandra =?utf-8?B?SMOhamtvdsOh?= on Thu, 30 Apr 2026 09:51:47 +0200)
> From: Alexandra Hájková <ahajkova@redhat.com>
> Cc: ahajkova@redhat.com
> Date: Thu, 30 Apr 2026 09:51:47 +0200
>
> gdb/NEWS | 14 +
> gdb/breakpoint.c | 472 ++++++++++++++++++
> gdb/breakpoint.h | 38 ++
> gdb/doc/gdb.texinfo | 45 ++
> .../gdb.base/adjust_breakpoint-2.cpp | 39 ++
> .../gdb.base/adjust_breakpoint-3.cpp | 41 ++
> .../gdb.base/adjust_breakpoint-4.cpp | 37 ++
> .../adjust_breakpoint-missing-source.exp | 55 ++
> gdb/testsuite/gdb.base/adjust_breakpoint.cpp | 40 ++
> gdb/testsuite/gdb.base/adjust_breakpoint.exp | 143 ++++++
> .../gdb.base/source-tracking-inline-1.c | 50 ++
> .../gdb.base/source-tracking-inline-2.c | 49 ++
> .../gdb.base/source-tracking-inline.exp | 80 +++
> 13 files changed, 1103 insertions(+)
> create mode 100644 gdb/testsuite/gdb.base/adjust_breakpoint-2.cpp
> create mode 100644 gdb/testsuite/gdb.base/adjust_breakpoint-3.cpp
> create mode 100644 gdb/testsuite/gdb.base/adjust_breakpoint-4.cpp
> create mode 100644 gdb/testsuite/gdb.base/adjust_breakpoint-missing-source.exp
> create mode 100644 gdb/testsuite/gdb.base/adjust_breakpoint.cpp
> create mode 100644 gdb/testsuite/gdb.base/adjust_breakpoint.exp
> create mode 100644 gdb/testsuite/gdb.base/source-tracking-inline-1.c
> create mode 100644 gdb/testsuite/gdb.base/source-tracking-inline-2.c
> create mode 100644 gdb/testsuite/gdb.base/source-tracking-inline.exp
Thanks. The documentation parts of this are approved, with two minor
comments:
> +@kindex maint info source-tracking-context
> +@item maint info source-tracking-context @var{num}
> +For source tracking breakpoints (@pxref{Set Breaks}), print the
^^^^^^^^^^^^^^^ ^^^^^^^^^^
Please use "source-tracking" consistently everywhere, since that's
what you used when you introduced this terminology. Also, the @pxref
above is to the wrong node, because this term is described in
"Breakpoints".
Reviewed-By: Eli Zaretskii <eliz@gnu.org>
prev parent reply other threads:[~2026-04-30 8:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-10 8:39 [PATCH v3] " Alexandra Hájková
2026-04-18 21:16 ` Andrew Burgess
2026-04-30 7:51 ` [PATCH v4] " Alexandra Hájková
2026-04-30 8:38 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=861pfw4zcz.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=ahajkova@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox