From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id XPLQOQkW82lObAUAWB0awg (envelope-from ) for ; Thu, 30 Apr 2026 04:42:49 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=iWUg0AFh; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id DC3F91E067; Thu, 30 Apr 2026 04:42:49 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 08CD91E067 for ; Thu, 30 Apr 2026 04:42:49 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id A874B4310D76 for ; Thu, 30 Apr 2026 08:42:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A874B4310D76 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=iWUg0AFh Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 843A54BB3BD8 for ; Thu, 30 Apr 2026 08:38:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 843A54BB3BD8 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 843A54BB3BD8 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777538324; cv=none; b=W9FJlhPebUVmbZHUBQPYY/d++5SYDc1phrMv21JD3aU96Rbcy2tAGu21bqh/Ejw44kq92KEFV+Z9KWIjoFxxc6yoku5OCJMXeTNS4n8OwGVYcvhSyscJbpj8kIyQY4NqN3oB0l4s7f0JdlLgj3fWF/pMrA92xlDUtk0R+ZFB5EE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777538324; c=relaxed/simple; bh=xi721swz+s8mmnML4Ex4mC6TBfrLLD3168JlJ2Kp8jE=; h=DKIM-Signature:Date:Message-Id:From:To:Subject:MIME-version; b=lTN6KCEAJ0LJOo93zehcTpMvPkGkN1PwXwKPdZl4KgRL+pSeTT8b8Bh/Feb8T8KFOceo2qN5rxnAL0VZ2m5X8kx8yG7KvBK5FICgcfTk6bRkM60zzajJd8ZW5aEBLItkZSHiArOYjSG2l0qCy/ixLPQmUY6cU8SXndm+q6bKTLc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 843A54BB3BD8 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wIMuw-00041m-S6; Thu, 30 Apr 2026 04:38:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=f/uD/dAvmizBDLNXHCIgsl7Adii6uuqtwoPzWcEPISo=; b=iWUg0AFhw+AGsS29UMpU 0p9Wa7Xgw+KWGxL+EnJL+I3+uf6s6f5vuocTrkdH737YANxbzZYHbRngZ2K/JG+Fi4zfX7gFvQZwH SwAVYUhhCjUYp9dNW4zuVNRQGQ0beWTtFssDHchO9m4jYwHJaYj7eBZk9wgtheeLe1M4FqxPCMTnQ ulwYpAugXi2mQ3dpEJg+5PHqunx4adVKHybSxn2Rcmhc2xhP6TbmFhVVrWfkQ4e9pSovRhqcIkVSb f9DjmNjWnWWBchMG6F+lzJIH0bTGm+iAA3VdsLv4xiiI+zx4HcXg9Bv6cy/dgOxRfNSo9HQN63sv/ oHCNxD6gDJDTIw==; Date: Thu, 30 Apr 2026 11:38:20 +0300 Message-Id: <861pfw4zcz.fsf@gnu.org> From: Eli Zaretskii To: Alexandra =?utf-8?B?SMOhamtvdsOh?= Cc: gdb-patches@sourceware.org In-Reply-To: <20260430075218.6278-1-ahajkova@redhat.com> (message from Alexandra =?utf-8?B?SMOhamtvdsOh?= on Thu, 30 Apr 2026 09:51:47 +0200) Subject: Re: [PATCH v4] gdb: Add source-tracking breakpoints feature References: <20260410084251.177366-1-ahajkova@redhat.com> <20260430075218.6278-1-ahajkova@redhat.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org > From: Alexandra Hájková > Cc: ahajkova@redhat.com > Date: Thu, 30 Apr 2026 09:51:47 +0200 > > gdb/NEWS | 14 + > gdb/breakpoint.c | 472 ++++++++++++++++++ > gdb/breakpoint.h | 38 ++ > gdb/doc/gdb.texinfo | 45 ++ > .../gdb.base/adjust_breakpoint-2.cpp | 39 ++ > .../gdb.base/adjust_breakpoint-3.cpp | 41 ++ > .../gdb.base/adjust_breakpoint-4.cpp | 37 ++ > .../adjust_breakpoint-missing-source.exp | 55 ++ > gdb/testsuite/gdb.base/adjust_breakpoint.cpp | 40 ++ > gdb/testsuite/gdb.base/adjust_breakpoint.exp | 143 ++++++ > .../gdb.base/source-tracking-inline-1.c | 50 ++ > .../gdb.base/source-tracking-inline-2.c | 49 ++ > .../gdb.base/source-tracking-inline.exp | 80 +++ > 13 files changed, 1103 insertions(+) > create mode 100644 gdb/testsuite/gdb.base/adjust_breakpoint-2.cpp > create mode 100644 gdb/testsuite/gdb.base/adjust_breakpoint-3.cpp > create mode 100644 gdb/testsuite/gdb.base/adjust_breakpoint-4.cpp > create mode 100644 gdb/testsuite/gdb.base/adjust_breakpoint-missing-source.exp > create mode 100644 gdb/testsuite/gdb.base/adjust_breakpoint.cpp > create mode 100644 gdb/testsuite/gdb.base/adjust_breakpoint.exp > create mode 100644 gdb/testsuite/gdb.base/source-tracking-inline-1.c > create mode 100644 gdb/testsuite/gdb.base/source-tracking-inline-2.c > create mode 100644 gdb/testsuite/gdb.base/source-tracking-inline.exp Thanks. The documentation parts of this are approved, with two minor comments: > +@kindex maint info source-tracking-context > +@item maint info source-tracking-context @var{num} > +For source tracking breakpoints (@pxref{Set Breaks}), print the ^^^^^^^^^^^^^^^ ^^^^^^^^^^ Please use "source-tracking" consistently everywhere, since that's what you used when you introduced this terminology. Also, the @pxref above is to the wrong node, because this term is described in "Breakpoints". Reviewed-By: Eli Zaretskii