Build failed on MinGW host, sh-elf target.

Build failed on MinGW host, sh-elf target.

[Masaki Muranaka]

Hello All,

GDB build was failed at ser-e7kpc.c on MinGW host, sh-elf target.
(there is no build failure on the linux host, sh-elf target.)

The error messages is follows:
../../src/gdb/ser-e7kpc.c:232: warning: implicit declaration of  
function `time'
make[2]: *** [ser-e7kpc.o] Error 1

- - - - - -
2006-05-06  Masaki Muranaka  <monaka@monami-software.com>

         * defs.h: Include <time.h> if HAVE_TIME_H is defined.

- - - - - -
Index: gdb/defs.h
===================================================================
RCS file: /cvs/src/src/gdb/defs.h,v
retrieving revision 1.194
diff -u -p -r1.194 defs.h
--- gdb/defs.h  25 Feb 2006 04:36:39 -0000      1.194
+++ gdb/defs.h  6 May 2006 04:02:33 -0000
@@ -39,6 +39,10 @@
#include <unistd.h>
#endif

+#ifdef HAVE_TIME_H
+#include <time.h>
+#endif
+
#include <fcntl.h>
/* First include ansidecl.h so we can use the various macro definitions

--
Masaki Muranaka
Monami software

Re: Build failed on MinGW host, sh-elf target.

[Daniel Jacobowitz]

On Sat, May 06, 2006 at 01:09:55PM +0900, Masaki Muranaka wrote:
> Hello All,
> 
> GDB build was failed at ser-e7kpc.c on MinGW host, sh-elf target.
> (there is no build failure on the linux host, sh-elf target.)
> 
> The error messages is follows:
> ../../src/gdb/ser-e7kpc.c:232: warning: implicit declaration of  
> function `time'
> make[2]: *** [ser-e7kpc.o] Error 1

> 2006-05-06  Masaki Muranaka  <monaka@monami-software.com>
> 
>         * defs.h: Include <time.h> if HAVE_TIME_H is defined.

Does this happen anywhere besides ser-e7kpc.c?  If not, I would rather
add it to just that file.

-- 
Daniel Jacobowitz
CodeSourcery

Re: Build failed on MinGW host, sh-elf target.

[Masaki Muranaka]

Hello, Daniel.

On 2006/05/16, at 1:58, Daniel Jacobowitz wrote:
>> 2006-05-06  Masaki Muranaka  <monaka@monami-software.com>
>>
>>         * defs.h: Include <time.h> if HAVE_TIME_H is defined.
>
> Does this happen anywhere besides ser-e7kpc.c?  If not, I would rather
> add it to just that file.

Hmm... It might be enough to add it to just ser-e7kpc.c.

As far as I built, only ser-e7kpc.c.
(I built targets m32r-elf, mips64-elf,
xstormy16-elf, arm-elf, i386-elf, sh-elf,
m32c-elf, v850-elf, m68k-elf
on i686-pc-mingw32 host.)


--
Masaki Muranaka
Monami software

Re: Build failed on MinGW host, sh-elf target.

[Daniel Jacobowitz]

On Tue, May 16, 2006 at 03:09:20PM +0900, Masaki Muranaka wrote:
> Hello, Daniel.
> 
> On 2006/05/16, at 1:58, Daniel Jacobowitz wrote:
> >>2006-05-06  Masaki Muranaka  <monaka@monami-software.com>
> >>
> >>        * defs.h: Include <time.h> if HAVE_TIME_H is defined.
> >
> >Does this happen anywhere besides ser-e7kpc.c?  If not, I would rather
> >add it to just that file.
> 
> Hmm... It might be enough to add it to just ser-e7kpc.c.
> 
> As far as I built, only ser-e7kpc.c.
> (I built targets m32r-elf, mips64-elf,
> xstormy16-elf, arm-elf, i386-elf, sh-elf,
> m32c-elf, v850-elf, m68k-elf
> on i686-pc-mingw32 host.)

Thanks.  I've checked in this, then.  Please let us know if you find
more problems!

-- 
Daniel Jacobowitz
CodeSourcery

2006-05-16  Daniel Jacobowitz  <dan@codesourcery.com>

	* ser-e7kpc.c: Include <time.h> if it is available.

Index: ser-e7kpc.c
===================================================================
RCS file: /cvs/src/src/gdb/ser-e7kpc.c,v
retrieving revision 1.12
diff -u -p -r1.12 ser-e7kpc.c
--- ser-e7kpc.c	17 Dec 2005 22:34:02 -0000	1.12
+++ ser-e7kpc.c	16 May 2006 20:20:10 -0000
@@ -33,6 +33,10 @@
 #include <sys/dos.h>
 #endif
 
+#ifdef HAVE_TIME_H
+#include <time.h>
+#endif
+
 static int e7000pc_open (struct serial *scb, const char *name);
 static void e7000pc_raw (struct serial *scb);
 static int e7000pc_readchar (struct serial *scb, int timeout);