Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Eli Zaretskii" <eliz@is.elta.co.il>
To: jimb@zwingli.cygnus.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA: document GDB's overlay support
Date: Sun, 25 Nov 2001 01:01:00 -0000	[thread overview]
Message-ID: <8582-Fri30Nov2001235720+0200-eliz@is.elta.co.il> (raw)
In-Reply-To: <20011130205837.ED4F15E9D8@zwingli.cygnus.com> (message from Jim Blandy on Fri, 30 Nov 2001 15:58:37 -0500 (EST))

> From: Jim Blandy <jimb@zwingli.cygnus.com>
> Date: Fri, 30 Nov 2001 15:58:37 -0500 (EST)
> 
> The weird part about this patch is that it includes a diagram --- the
> GDB manual's first.  This makes GDB's manual a lot more sensitive to
> the exact versions of the texinfo tools.  This patch adds a new file,
> README-IMAGES, which explains exactly what you need.  In the case of
> `makeinfo', even the latest release doesn't work; I include a patch
> for it.

I don't mind adding this hair, provided that the parts which don't
work without patching standard distributions, such as what needs a
patched makeinfo, are by default disabled.  We can then tell people
who want those hairy features to flip some flag or @set something,
before they produce the manual.

>         * jimb.texinfo-4-image-path.patch: New file.

Is it possible to avoid file names that will cause trouble on 8+3
filesystems?  If not, we need to add a line to fnchange.lst.

> *** gdb/doc/gdb.texinfo	2001/09/12 19:49:52	1.51
> --- gdb/doc/gdb.texinfo	2001/10/09 16:40:00

This patch is approved, with the following minor comments:

 - Please use "@value{GDBN}" instead of "GDB".

 - I suggest an index entry here:

> + @itemize @bullet
> + @item
> + You can set breakpoints in functions in unmapped overlays, as long as
> + GDB can write to the overlay at its load address.
> + @item
> + GDB can not set hardware or simulator-based breakpoints in unmapped
> + overlays.  However, if you set a breakpoint at the end of your overlay
> + manager (and tell GDB which overlays are now mapped, if you are using
> + manual overlay management), GDB will re-set its breakpoints properly.
> + @end itemize

Something like "@cindex breakpoints, and overlays", for example.

> + @node Overlay Sample Program
> + @section Overlay Sample Program
> + @cindex overlay sample program
> + @cindex overlay example program

It is not very useful to have two index entries which begin with the
same string and point to the same place.  I think "overlay example
program" should be enough.

> + *** makeinfo/makeinfo.c.~1~	Sun Sep 19 10:24:44 1999
> + --- makeinfo/makeinfo.c	Wed Sep 26 10:49:48 2001

Did you send this to the Texinfo maintainer?  If so, is this patch
available in Texinfo 4.0d, the latest pretest on alpha.gnu?

In any case, if the only problem is that makeinfo doesn't search the
include directories for images, people could force it to DTRT by
simlpy putting the image files in the current directory, right?
Perhaps it's better to tell them to do this, instead of rebuilding
makeinfo?


WARNING: multiple messages have this Message-ID
From: "Eli Zaretskii" <eliz@is.elta.co.il>
To: jimb@zwingli.cygnus.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA: document GDB's overlay support
Date: Fri, 30 Nov 2001 13:58:00 -0000	[thread overview]
Message-ID: <8582-Fri30Nov2001235720+0200-eliz@is.elta.co.il> (raw)
Message-ID: <20011130135800.CN34sq6lYvB2Gjcyjl5GaLwANh0OZ_a3T9UoXiilRbs@z> (raw)
In-Reply-To: <20011130205837.ED4F15E9D8@zwingli.cygnus.com>

> From: Jim Blandy <jimb@zwingli.cygnus.com>
> Date: Fri, 30 Nov 2001 15:58:37 -0500 (EST)
> 
> The weird part about this patch is that it includes a diagram --- the
> GDB manual's first.  This makes GDB's manual a lot more sensitive to
> the exact versions of the texinfo tools.  This patch adds a new file,
> README-IMAGES, which explains exactly what you need.  In the case of
> `makeinfo', even the latest release doesn't work; I include a patch
> for it.

I don't mind adding this hair, provided that the parts which don't
work without patching standard distributions, such as what needs a
patched makeinfo, are by default disabled.  We can then tell people
who want those hairy features to flip some flag or @set something,
before they produce the manual.

>         * jimb.texinfo-4-image-path.patch: New file.

Is it possible to avoid file names that will cause trouble on 8+3
filesystems?  If not, we need to add a line to fnchange.lst.

> *** gdb/doc/gdb.texinfo	2001/09/12 19:49:52	1.51
> --- gdb/doc/gdb.texinfo	2001/10/09 16:40:00

This patch is approved, with the following minor comments:

 - Please use "@value{GDBN}" instead of "GDB".

 - I suggest an index entry here:

> + @itemize @bullet
> + @item
> + You can set breakpoints in functions in unmapped overlays, as long as
> + GDB can write to the overlay at its load address.
> + @item
> + GDB can not set hardware or simulator-based breakpoints in unmapped
> + overlays.  However, if you set a breakpoint at the end of your overlay
> + manager (and tell GDB which overlays are now mapped, if you are using
> + manual overlay management), GDB will re-set its breakpoints properly.
> + @end itemize

Something like "@cindex breakpoints, and overlays", for example.

> + @node Overlay Sample Program
> + @section Overlay Sample Program
> + @cindex overlay sample program
> + @cindex overlay example program

It is not very useful to have two index entries which begin with the
same string and point to the same place.  I think "overlay example
program" should be enough.

> + *** makeinfo/makeinfo.c.~1~	Sun Sep 19 10:24:44 1999
> + --- makeinfo/makeinfo.c	Wed Sep 26 10:49:48 2001

Did you send this to the Texinfo maintainer?  If so, is this patch
available in Texinfo 4.0d, the latest pretest on alpha.gnu?

In any case, if the only problem is that makeinfo doesn't search the
include directories for images, people could force it to DTRT by
simlpy putting the image files in the current directory, right?
Perhaps it's better to tell them to do this, instead of rebuilding
makeinfo?


  reply	other threads:[~2001-11-30 21:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-11-23 15:06 Jim Blandy
2001-11-25  1:01 ` Eli Zaretskii [this message]
2001-11-25  8:33   ` Jim Blandy
2001-11-25 10:57     ` Eli Zaretskii
2001-11-30 22:53       ` Eli Zaretskii
2001-11-30 14:53     ` Jim Blandy
2001-12-02 21:57     ` Andrew Cagney
2001-11-30 13:58   ` Eli Zaretskii
2001-11-30 12:57 ` Jim Blandy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8582-Fri30Nov2001235720+0200-eliz@is.elta.co.il \
    --to=eliz@is.elta.co.il \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jimb@zwingli.cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox