Re: [PATCH 1/2] gdb: use XML_GetCurrentLineNumber64 with expat >= 2.9.0

[Simon Marchi <simark@simark.ca>]

On 10/13/26 5:23 AM, Tom de Vries wrote:
> On 10/11/26 3:31 PM, Simon Marchi wrote:
>> When building against expat 2.9.0, I get:
>>
>>        CXX    xml-support.o
>>      /home/smarchi/src/binutils-gdb/gdb/xml-support.c:182:39: error: 'XML_Size XML_GetCurrentLineNumber(XML_Parser)' is deprecated: please use XML_GetCurrentLineNumber64 instead [-Werror=deprecated-declarations]
>>        182 |   int line = XML_GetCurrentLineNumber (m_expat_parser);
>>            |              ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
>>
>> The functions that return XML_Size were deprecated in favor of the new
>> functions, with suffix 64, that return uint64_t.
>>
>> Add a gdb_xml_get_current_line_number wrapper in gdb_expat.h, which
>> calls XML_GetCurrentLineNumber64 with expat 2.9.0 and later, and
>> XML_GetCurrentLineNumber otherwise.  Use it in xml-support.c.
>>
>> The uint64_t gets truncated when converted to int, but that was already
>> true before, as XML_Size is 64-bits when building on an arch where
>> unsigned long is 64-bits.
>>
> 
> Hi Simon.
> 
> I ran into the same issue on Tumbleweed.
> 
> I applied this series, and I managed to complete the build.
> 
> Both patches LGTM.
> 
> Reviewed-By: Tom de Vries <tdevries@suse.de>

Thanks, pushed both.

Simon