From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id oKPWJFBGzmpHaQIAWB0awg (envelope-from ) for ; Tue, 13 Oct 2026 10:55:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1791903312; bh=uvxtrhHD1pFO+6lNSgJRZvSY7sgWhe3255DoKxGH5rA=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=LmhogRRNEq7Tt8MIDa7ubWRtZFghypnKQ/67CTvTeR9aTjZcxsRnXiuj/7Q6i2Cc+ zECcWTSrAF9iYLEhBWVyLXdBkrFKT+xX4+3LHd2oFRrGLCrRHn+3OyT026Py1e0DvI dbZy/F8GlLqJW6xk+DJypP7B0iodsToAxQ4GU4Es= Received: by simark.ca (Postfix, from userid 112) id 79BEA1E051; Tue, 13 Oct 2026 10:55:12 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=icTqOdRO; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5AE1C1E04E for ; Tue, 13 Oct 2026 10:55:11 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E3C174BA23E2 for ; Tue, 13 Oct 2026 14:55:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E3C174BA23E2 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=icTqOdRO Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 39C044BA23F9 for ; Tue, 13 Oct 2026 14:54:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 39C044BA23F9 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 39C044BA23F9 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1791903286; cv=none; b=sFjc68t/bXDwKYXvEP3F+vhz/oP6fmE6W/6RopFN4a5OtZCWPklVuESKhUpZsgRYWtb3V5fhgm0LNwq/hcEN4imG0dO72mknfTDX9HQ5LF6uET66HB1Etpjf1X9QN2RqaUuf+9hCEpEso2+WyJhwl2gGaLzYhQkxv3VJsiZQnfE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1791903286; c=relaxed/simple; bh=uvxtrhHD1pFO+6lNSgJRZvSY7sgWhe3255DoKxGH5rA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=kY6oXt0Gmg4S52kAMPApxTiEGbMOzHv4l/lAtCrHvPjAEiB0QM+85G5MniQkNke0rkt5Rqt9eAJHgILK2s4CNCZOKxQh7Hn8b1itXSIgbu23xuw0Z+x5wnFfY/6r8DOgBpmhF1zGbsgw5yzAbl3e2hewG1hYPajagpduSyYwn/A= ARC-Authentication-Results: i=1; sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1791903281; bh=uvxtrhHD1pFO+6lNSgJRZvSY7sgWhe3255DoKxGH5rA=; h=Date:Subject:To:References:From:In-Reply-To:From; b=icTqOdROxUArz3Bn27V/5BEuJnu6ADAc1zv5arFHiWlzI4veOgDdrU8rRe7c0nZjW 6bOGPJyFpwTWZ4bS8NxQDC+CBj3aXXSwqV35V7OcRRrO8e8c9RFI/jfpI7Re8jabQ/ 10MCCJYfxU/fa6xnoMVozD8PBVK8qtalQBZbbsjc= Received: by simark.ca (Postfix) id 610E91E04E; Tue, 13 Oct 2026 10:54:41 -0400 (EDT) Message-ID: <84eceeb6-2e20-4246-9584-2c7c8c2b0b09@simark.ca> Date: Tue, 13 Oct 2026 10:54:40 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] gdb: use XML_GetCurrentLineNumber64 with expat >= 2.9.0 To: Tom de Vries , Simon Marchi , gdb-patches@sourceware.org References: <20261011133136.472634-1-simon.marchi@efficios.com> <89c300fa-77b0-4524-b3ee-11d58af2125c@suse.de> Content-Language: fr From: Simon Marchi In-Reply-To: <89c300fa-77b0-4524-b3ee-11d58af2125c@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 10/13/26 5:23 AM, Tom de Vries wrote: > On 10/11/26 3:31 PM, Simon Marchi wrote: >> When building against expat 2.9.0, I get: >> >> CXX xml-support.o >> /home/smarchi/src/binutils-gdb/gdb/xml-support.c:182:39: error: 'XML_Size XML_GetCurrentLineNumber(XML_Parser)' is deprecated: please use XML_GetCurrentLineNumber64 instead [-Werror=deprecated-declarations] >> 182 | int line = XML_GetCurrentLineNumber (m_expat_parser); >> | ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~ >> >> The functions that return XML_Size were deprecated in favor of the new >> functions, with suffix 64, that return uint64_t. >> >> Add a gdb_xml_get_current_line_number wrapper in gdb_expat.h, which >> calls XML_GetCurrentLineNumber64 with expat 2.9.0 and later, and >> XML_GetCurrentLineNumber otherwise. Use it in xml-support.c. >> >> The uint64_t gets truncated when converted to int, but that was already >> true before, as XML_Size is 64-bits when building on an arch where >> unsigned long is 64-bits. >> > > Hi Simon. > > I ran into the same issue on Tumbleweed. > > I applied this series, and I managed to complete the build. > > Both patches LGTM. > > Reviewed-By: Tom de Vries Thanks, pushed both. Simon