Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] testsuite: Disable backslash_in_multi_line_command_test for old DejaGnus
Date: Mon, 13 Mar 2017 21:55:00 -0000	[thread overview]
Message-ID: <84dc18d7-9c44-8d75-43e5-d1c06e3954dd@redhat.com> (raw)
In-Reply-To: <20170313212749.9607-2-simon.marchi@ericsson.com>

OK.

Thanks,
Pedro Alves

On 03/13/2017 09:27 PM, Simon Marchi wrote:
> I noticed that backslash_in_multi_line_command_test in
> gdb.base/commands.exp failed on our RHEL6 servers.  I traced it to the
> old version of DejaGnu (1.4.4).  I have found that instead of receiving
> the expected:
> 
>   "print \\\nargc\n"
> 
> gdb received:
> 
>   "print  argc\n"
> 
> thus breaking the test and its purpose.  Versionof DejaGnu < 1.5 mess
> up sending "\\\n", it somehow gets replaced with a space.  I found that
> the following commit in DejaGnu fixed the issue:
> 
> http://git.savannah.gnu.org/cgit/dejagnu.git/commit/lib/remote.exp?id=3f39294f5cd6802858838d3bcc0ccce847ae17f2
> 
> Even though the commit is almost 10 years old, the following release of
> DejaGnu was only in 2013, which is why we still have systems with the
> old code.
> 
> If the DejaGnu version is < 1.5, we just skip the test.


  reply	other threads:[~2017-03-13 21:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-13 21:28 [PATCH 1/2] testsuite: Introduce dejagnu_version Simon Marchi
2017-03-13 21:28 ` [PATCH 2/2] testsuite: Disable backslash_in_multi_line_command_test for old DejaGnus Simon Marchi
2017-03-13 21:55   ` Pedro Alves [this message]
2017-03-13 21:54 ` [PATCH 1/2] testsuite: Introduce dejagnu_version Pedro Alves
2017-03-13 22:03   ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84dc18d7-9c44-8d75-43e5-d1c06e3954dd@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@ericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox