From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70792 invoked by alias); 13 Mar 2017 21:55:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 70772 invoked by uid 89); 13 Mar 2017 21:55:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:970, our X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 13 Mar 2017 21:55:00 +0000 Received: from smtp.corp.redhat.com (int-mx16.intmail.prod.int.phx2.redhat.com [10.5.11.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 79D7F81222; Mon, 13 Mar 2017 21:55:01 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id D79CE2D5C1; Mon, 13 Mar 2017 21:55:00 +0000 (UTC) Subject: Re: [PATCH 2/2] testsuite: Disable backslash_in_multi_line_command_test for old DejaGnus To: Simon Marchi , gdb-patches@sourceware.org References: <20170313212749.9607-1-simon.marchi@ericsson.com> <20170313212749.9607-2-simon.marchi@ericsson.com> From: Pedro Alves Message-ID: <84dc18d7-9c44-8d75-43e5-d1c06e3954dd@redhat.com> Date: Mon, 13 Mar 2017 21:55:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170313212749.9607-2-simon.marchi@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-03/txt/msg00208.txt.bz2 OK. Thanks, Pedro Alves On 03/13/2017 09:27 PM, Simon Marchi wrote: > I noticed that backslash_in_multi_line_command_test in > gdb.base/commands.exp failed on our RHEL6 servers. I traced it to the > old version of DejaGnu (1.4.4). I have found that instead of receiving > the expected: > > "print \\\nargc\n" > > gdb received: > > "print argc\n" > > thus breaking the test and its purpose. Versionof DejaGnu < 1.5 mess > up sending "\\\n", it somehow gets replaced with a space. I found that > the following commit in DejaGnu fixed the issue: > > http://git.savannah.gnu.org/cgit/dejagnu.git/commit/lib/remote.exp?id=3f39294f5cd6802858838d3bcc0ccce847ae17f2 > > Even though the commit is almost 10 years old, the following release of > DejaGnu was only in 2013, which is why we still have systems with the > old code. > > If the DejaGnu version is < 1.5, we just skip the test.