Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jim Ingham <jingham@apple.com>
To: Daniel Jacobowitz <drow@mvista.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: Obvious fix in values.c?
Date: Fri, 19 Apr 2002 16:23:00 -0000	[thread overview]
Message-ID: <84457DE2-53EC-11D6-8B7C-00039379E320@apple.com> (raw)
In-Reply-To: <20020419185837.A14276@nevyn.them.org>

Daniel,

I'll take a look at it after Apple's WWDC (mid-May).  I won't have time 
till then.

Jim

On Friday, April 19, 2002, at 03:58  PM, Daniel Jacobowitz wrote:

> On Fri, Apr 19, 2002 at 02:28:44PM -0700, Jim Ingham wrote:
>> Do folks agree that this falls under the obvious fix rule?  It doesn't
>> seem safe to assume that all demangled names will contain a space (and
>> in fact, gdb crashed on someone when the assumption was proved 
>> false...).
>>
>> 2002-04-19  Jim Ingham <jingham@apple.com>
>>
>> 	* values.c (value_headof): Don't assume all demangled names contain
>> a space.
>
> Could I please get you to solve this properly?  Kill the one and only
> use of this function in printcmd.c via value_from_vtable_info.  If you
> simply cast the pointer to a pointer to the proper base type, found via
> value_rtti_type, this function can die.  It should just work (and/or be
> more useful than the current behavior).
>
> --
> Daniel Jacobowitz                           Carnegie Mellon University
> MontaVista Software                         Debian GNU/Linux Developer
>
--
Jim Ingham                                   jingham@apple.com
Developer Tools - gdb
Apple Computer


  reply	other threads:[~2002-04-19 23:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-04-19 14:28 Jim Ingham
2002-04-19 15:58 ` Daniel Jacobowitz
2002-04-19 16:23   ` Jim Ingham [this message]
2002-04-19 16:43     ` Andrew Cagney
2002-04-19 18:06       ` Jim Ingham
2002-05-11 16:46   ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84457DE2-53EC-11D6-8B7C-00039379E320@apple.com \
    --to=jingham@apple.com \
    --cc=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox