From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2614 invoked by alias); 19 Apr 2002 23:23:58 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 2577 invoked from network); 19 Apr 2002 23:23:56 -0000 Received: from unknown (HELO mail-out1.apple.com) (17.254.0.52) by sources.redhat.com with SMTP; 19 Apr 2002 23:23:56 -0000 Received: from mailgate2.apple.com (A17-129-100-225.apple.com [17.129.100.225]) by mail-out1.apple.com (8.11.3/8.11.3) with ESMTP id g3JNNtt04535 for ; Fri, 19 Apr 2002 16:23:56 -0700 (PDT) Received: from scv2.apple.com (scv2.apple.com) by mailgate2.apple.com (Content Technologies SMTPRS 4.2.1) with ESMTP id ; Fri, 19 Apr 2002 16:23:55 -0700 Received: from inghji (inghji.apple.com [17.202.40.220]) by scv2.apple.com (8.11.3/8.11.3) with ESMTP id g3JNNti04917; Fri, 19 Apr 2002 16:23:55 -0700 (PDT) Date: Fri, 19 Apr 2002 16:23:00 -0000 Subject: Re: Obvious fix in values.c? Content-Type: text/plain; charset=US-ASCII; format=flowed Mime-Version: 1.0 (Apple Message framework v481) Cc: gdb-patches@sources.redhat.com To: Daniel Jacobowitz From: Jim Ingham In-Reply-To: <20020419185837.A14276@nevyn.them.org> Message-Id: <84457DE2-53EC-11D6-8B7C-00039379E320@apple.com> Content-Transfer-Encoding: 7bit X-SW-Source: 2002-04/txt/msg00645.txt.bz2 Daniel, I'll take a look at it after Apple's WWDC (mid-May). I won't have time till then. Jim On Friday, April 19, 2002, at 03:58 PM, Daniel Jacobowitz wrote: > On Fri, Apr 19, 2002 at 02:28:44PM -0700, Jim Ingham wrote: >> Do folks agree that this falls under the obvious fix rule? It doesn't >> seem safe to assume that all demangled names will contain a space (and >> in fact, gdb crashed on someone when the assumption was proved >> false...). >> >> 2002-04-19 Jim Ingham >> >> * values.c (value_headof): Don't assume all demangled names contain >> a space. > > Could I please get you to solve this properly? Kill the one and only > use of this function in printcmd.c via value_from_vtable_info. If you > simply cast the pointer to a pointer to the proper base type, found via > value_rtti_type, this function can die. It should just work (and/or be > more useful than the current behavior). > > -- > Daniel Jacobowitz Carnegie Mellon University > MontaVista Software Debian GNU/Linux Developer > -- Jim Ingham jingham@apple.com Developer Tools - gdb Apple Computer