From: Eli Zaretskii <eliz@gnu.org>
To: Aaron Gamble <agamble@google.com>
Cc: tromey@redhat.com, gdb-patches@sourceware.org
Subject: Re: [RFC] Thread Name Printers
Date: Sat, 25 Aug 2012 05:28:00 -0000 [thread overview]
Message-ID: <83zk5jfsoc.fsf@gnu.org> (raw)
In-Reply-To: <CAHX8C+KctA8K9tWZZug5o6Z+5f6GB8hNJ-qaa2PyW7=nHQAp5Q@mail.gmail.com>
> Date: Fri, 24 Aug 2012 15:02:04 -0700
> From: Aaron Gamble <agamble@google.com>
> Cc: gdb-patches@sourceware.org
>
> New patch. See inline comments.
Thanks. I have comments about the documentation part.
> +Thread name printers are registered and may be disabled and enabled by the
> +provided alias when the printer was registered.
What does it mean "enabled by the provided alias"?
> +Once a printer has been defined, it can be instantiated and added to the global
> +list of printers as follows:
> +@code{my_printer_class().add_printer("my printer alias")}
The last line should be in @smallexample block.
> +@defun thread_name_printer.prepare (@var{self})
> +@value{GDBN} will call this method for each printer at the beginning of the
> +'info threads' command.
"info threads" should be in @code and without the quotes.
> +method in each enabled printer until a string is returned. It is up to each thread printer
^^
Two spaces here.
> +@var{thread_info} is the InferiorThread as defined in @pxref{Threads In Python}.
@pxref is for text in parentheses. You want @ref here.
prev parent reply other threads:[~2012-08-25 5:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-21 20:59 Aaron Gamble
2012-08-22 19:39 ` Tom Tromey
2012-08-23 0:29 ` Aaron Gamble
2012-08-23 16:18 ` Tom Tromey
2012-08-24 22:00 ` Aaron Gamble
2012-08-24 22:02 ` Aaron Gamble
2012-08-25 5:28 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zk5jfsoc.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=agamble@google.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox