From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-94150-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 2878 invoked by alias); 25 Aug 2012 05:28:30 -0000
Received: (qmail 2870 invoked by uid 22791); 25 Aug 2012 05:28:29 -0000
X-SWARE-Spam-Status: No, hits=-4.1 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,RCVD_IN_NIX_SPAM,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout21.012.net.il (HELO mtaout21.012.net.il) (80.179.55.169)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 25 Aug 2012 05:28:15 +0000
Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0M9A00F00PIMYF00@a-mtaout21.012.net.il> for gdb-patches@sourceware.org; Sat, 25 Aug 2012 08:26:36 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M9A00FGDPS6PM80@a-mtaout21.012.net.il>; Sat, 25 Aug 2012 08:26:31 +0300 (IDT)
Date: Sat, 25 Aug 2012 05:28:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFC] Thread Name Printers
In-reply-to: <CAHX8C+KctA8K9tWZZug5o6Z+5f6GB8hNJ-qaa2PyW7=nHQAp5Q@mail.gmail.com>
To: Aaron Gamble <agamble@google.com>
Cc: tromey@redhat.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83zk5jfsoc.fsf@gnu.org>
References: <CAHX8C+LvZKv2_98u+38Y7P08pgK0_a9uRd3KJ7HiU9zehgQiUQ@mail.gmail.com> <87ipcasomu.fsf@fleche.redhat.com> <CAHX8C+LA1OpxaQKdoDKSL8wZ8Pzi3rsOLhSEY_gJXFynNCwbaQ@mail.gmail.com> <87lih5popk.fsf@fleche.redhat.com> <CAHX8C+KPH3dBcu7sxBnPj_PHkD1uyJ=ruVNXS74_gDMD0vnHng@mail.gmail.com> <CAHX8C+KctA8K9tWZZug5o6Z+5f6GB8hNJ-qaa2PyW7=nHQAp5Q@mail.gmail.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-08/txt/msg00779.txt.bz2

> Date: Fri, 24 Aug 2012 15:02:04 -0700
> From: Aaron Gamble <agamble@google.com>
> Cc: gdb-patches@sourceware.org
> 
> New patch. See inline comments.

Thanks.  I have comments about the documentation part.

> +Thread name printers are registered and may be disabled and enabled by the
> +provided alias when the printer was registered.

What does it mean "enabled by the provided alias"?

> +Once a printer has been defined, it can be instantiated and added to the global
> +list of printers as follows:
> +@code{my_printer_class().add_printer("my printer alias")}

The last line should be in @smallexample block.

> +@defun thread_name_printer.prepare (@var{self})
> +@value{GDBN} will call this method for each printer at the beginning of the
> +'info threads' command.

"info threads" should be in @code and without the quotes.

> +method in each enabled printer until a string is returned. It is up to each thread printer
                                                            ^^
Two spaces here.

> +@var{thread_info} is the InferiorThread as defined in @pxref{Threads In Python}.

@pxref is for text in parentheses.  You want @ref here.