Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Siva Chandra <sivachandra@google.com>
Cc: gdb-patches@sourceware.org, pmuldoon@redhat.com
Subject: Re: [RFC] New method gdb.Frame.arch_name which return's the name of frame's architecture
Date: Fri, 11 Jan 2013 15:43:00 -0000	[thread overview]
Message-ID: <83zk0fu3mg.fsf@gnu.org> (raw)
In-Reply-To: <CAGyQ6gw4zq4NQhKQ+-Gzuma+=sLTvnuzi5J5tVnKTdHJMZX=NA@mail.gmail.com>

> Date: Fri, 11 Jan 2013 06:56:22 -0800
> From: Siva Chandra <sivachandra@google.com>
> Cc: Phil Muldoon <pmuldoon@redhat.com>
> 
> Attached is a patch which adds a new method 'arch_name' to the class
> gdb.Frame. This new method returns the name of the frame's
> architecture as a string value.

Thanks.

> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -39,6 +39,9 @@ Lynx 178 PowerPC		powerpc-*-lynx*178
>  
>    ** Python 3 is now supported (in addition to Python 2.4 or later)
>  
> +  ** New method 'arch_name' added to gdb.Frame class which returns
> +     the name of the frame's architecture.

We describe the _state_ of GDB, not the actions which led to that
state.  So it would be better to reword like this:

  A new method 'arch_name' of the gdb.Frame class returns the name of
  the frame's architecture.

> +@defun Frame.arch_name ()
> +Returns the name (string value) of the frame's architecture.

"Return", not "Returns", for consistency with other method
descriptions.

The documentation parts are OK with these changes.


  reply	other threads:[~2013-01-11 15:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-11 14:56 Siva Chandra
2013-01-11 15:43 ` Eli Zaretskii [this message]
2013-01-14 21:44 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83zk0fu3mg.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=pmuldoon@redhat.com \
    --cc=sivachandra@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox