From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-97602-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 29670 invoked by alias); 11 Jan 2013 15:43:28 -0000
Received: (qmail 29580 invoked by uid 22791); 11 Jan 2013 15:43:25 -0000
X-SWARE-Spam-Status: No, hits=-4.5 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 Jan 2013 15:43:16 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MGG00C00WUDFO00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Fri, 11 Jan 2013 17:43:13 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MGG00C52X016880@a-mtaout22.012.net.il>; Fri, 11 Jan 2013 17:43:13 +0200 (IST)
Date: Fri, 11 Jan 2013 15:43:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFC] New method gdb.Frame.arch_name which return's the name of frame's architecture
In-reply-to: <CAGyQ6gw4zq4NQhKQ+-Gzuma+=sLTvnuzi5J5tVnKTdHJMZX=NA@mail.gmail.com>
To: Siva Chandra <sivachandra@google.com>
Cc: gdb-patches@sourceware.org, pmuldoon@redhat.com
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83zk0fu3mg.fsf@gnu.org>
References: <CAGyQ6gw4zq4NQhKQ+-Gzuma+=sLTvnuzi5J5tVnKTdHJMZX=NA@mail.gmail.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2013-01/txt/msg00232.txt.bz2

> Date: Fri, 11 Jan 2013 06:56:22 -0800
> From: Siva Chandra <sivachandra@google.com>
> Cc: Phil Muldoon <pmuldoon@redhat.com>
> 
> Attached is a patch which adds a new method 'arch_name' to the class
> gdb.Frame. This new method returns the name of the frame's
> architecture as a string value.

Thanks.

> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -39,6 +39,9 @@ Lynx 178 PowerPC		powerpc-*-lynx*178
>  
>    ** Python 3 is now supported (in addition to Python 2.4 or later)
>  
> +  ** New method 'arch_name' added to gdb.Frame class which returns
> +     the name of the frame's architecture.

We describe the _state_ of GDB, not the actions which led to that
state.  So it would be better to reword like this:

  A new method 'arch_name' of the gdb.Frame class returns the name of
  the frame's architecture.

> +@defun Frame.arch_name ()
> +Returns the name (string value) of the frame's architecture.

"Return", not "Returns", for consistency with other method
descriptions.

The documentation parts are OK with these changes.