From: Eli Zaretskii <eliz@gnu.org>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org, ARistovski@qnx.com, gbenson@redhat.com
Subject: Re: [PATCH v11 6/7] Validate symbol file using build-id
Date: Thu, 23 Jul 2015 17:25:00 -0000 [thread overview]
Message-ID: <83zj2m3hx1.fsf@gnu.org> (raw)
In-Reply-To: <20150723172203.1176.24671.stgit@host1.jankratochvil.net>
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> Cc: Aleksandar Ristovski <ARistovski@qnx.com>, Gary Benson <gbenson@redhat.com>
> Date: Thu, 23 Jul 2015 19:22:03 +0200
>
> Consumer part of the "build-id" attribute.
>
> gdb/ChangeLog
> 2015-07-15 Aleksandar Ristovski <aristovski@qnx.com
> Jan Kratochvil <jan.kratochvil@redhat.com>
>
> Validate symbol file using build-id.
> * NEWS (Changes since GDB 7.10): Add 'set validate-build-id'
> and 'show validate-build-id'. Add build-id attribute.
> * solib-darwin.c (_initialize_darwin_solib): Assign validate value.
> * solib-dsbt.c (_initialize_dsbt_solib): Ditto.
> * solib-frv.c (_initialize_frv_solib): Ditto.
> * solib-spu.c (set_spu_solib_ops): Ditto.
> * solib-svr4.c: Include rsp-low.h.
> (NOTE_GNU_BUILD_ID_NAME): New define.
> (svr4_validate): New function.
> (svr4_copy_library_list): Duplicate field build_id.
> (library_list_start_library): Parse 'build-id' attribute.
> (svr4_library_attributes): Add 'build-id' attribute.
> (_initialize_svr4_solib): Assign validate value.
> * solib-target.c (solib.h): Include.
> (_initialize_solib_target): Assign validate value.
> * solib.c (validate_build_id, show_validate_build_id): New.
> (solib_map_sections): Use ops->validate.
> (clear_so): Free build_id.
> (default_solib_validate): New function.
> (_initialize_solib): Add "validate-build-id".
> * solib.h (default_solib_validate): New declaration.
> * solist.h (struct so_list): New fields 'build_idsz' and 'build_id'.
> (target_so_ops): New field 'validate'.
>
> gdb/doc/ChangeLog
> 2015-07-15 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> * gdb.texinfo (Files): Add 'set validate-build-id'
> and 'show validate-build-id'.
The documentation parts are OK.
Thanks.
next prev parent reply other threads:[~2015-07-23 17:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-23 17:21 [PATCH v11 0/7] Validate binary before use Jan Kratochvil
2015-07-23 17:21 ` [PATCH v11 1/7] Create empty common/linux-maps.[ch] and common/target-utils.[ch] Jan Kratochvil
2015-07-23 17:21 ` [PATCH v11 2/7] Move gdb_regex* to common/ Jan Kratochvil
2015-07-23 17:21 ` [PATCH v11 3/7] Prepare linux_find_memory_regions_full & co. for move Jan Kratochvil
2015-07-23 17:22 ` [PATCH v11 5/7] gdbserver build-id attribute generator Jan Kratochvil
2015-07-23 17:24 ` Eli Zaretskii
2015-07-23 17:22 ` [PATCH v11 7/7] Tests for validate symbol file using build-id Jan Kratochvil
2015-07-23 17:22 ` [PATCH v11 6/7] Validate " Jan Kratochvil
2015-07-23 17:25 ` Eli Zaretskii [this message]
2015-07-23 17:22 ` [PATCH v11 4/7] Move linux_find_memory_regions_full & co Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zj2m3hx1.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=ARistovski@qnx.com \
--cc=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox