From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-124582-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 2043 invoked by alias); 23 Jul 2015 17:25:36 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 2031 invoked by uid 89); 23 Jul 2015 17:25:36 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout24.012.net.il
Received: from mtaout24.012.net.il (HELO mtaout24.012.net.il) (80.179.55.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Jul 2015 17:25:34 +0000
Received: from conversion-daemon.mtaout24.012.net.il by mtaout24.012.net.il (HyperSendmail v2007.08) id <0NRY00500A1JLP00@mtaout24.012.net.il> for gdb-patches@sourceware.org; Thu, 23 Jul 2015 20:17:04 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout24.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NRY004I1AOF3X30@mtaout24.012.net.il>; Thu, 23 Jul 2015 20:17:03 +0300 (IDT)
Date: Thu, 23 Jul 2015 17:25:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH v11 6/7] Validate symbol file using build-id
In-reply-to: <20150723172203.1176.24671.stgit@host1.jankratochvil.net>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org, ARistovski@qnx.com, gbenson@redhat.com
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83zj2m3hx1.fsf@gnu.org>
References: <20150723172109.1176.3332.stgit@host1.jankratochvil.net> <20150723172203.1176.24671.stgit@host1.jankratochvil.net>
X-IsSubscribed: yes
X-SW-Source: 2015-07/txt/msg00653.txt.bz2

> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> Cc: Aleksandar Ristovski <ARistovski@qnx.com>,        Gary Benson <gbenson@redhat.com>
> Date: Thu, 23 Jul 2015 19:22:03 +0200
> 
> Consumer part of the "build-id" attribute.
> 
> gdb/ChangeLog
> 2015-07-15  Aleksandar Ristovski  <aristovski@qnx.com
> 	    Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
> 	Validate symbol file using build-id.
> 	* NEWS (Changes since GDB 7.10): Add 'set validate-build-id'
> 	and 'show validate-build-id'.  Add build-id attribute.
> 	* solib-darwin.c (_initialize_darwin_solib): Assign validate value.
> 	* solib-dsbt.c (_initialize_dsbt_solib): Ditto.
> 	* solib-frv.c (_initialize_frv_solib): Ditto.
> 	* solib-spu.c (set_spu_solib_ops): Ditto.
> 	* solib-svr4.c: Include rsp-low.h.
> 	(NOTE_GNU_BUILD_ID_NAME): New define.
> 	(svr4_validate): New function.
> 	(svr4_copy_library_list): Duplicate field build_id.
> 	(library_list_start_library): Parse 'build-id' attribute.
> 	(svr4_library_attributes): Add 'build-id' attribute.
> 	(_initialize_svr4_solib): Assign validate value.
> 	* solib-target.c (solib.h): Include.
> 	(_initialize_solib_target): Assign validate value.
> 	* solib.c (validate_build_id, show_validate_build_id): New.
> 	(solib_map_sections): Use ops->validate.
> 	(clear_so): Free build_id.
> 	(default_solib_validate): New function.
> 	(_initialize_solib): Add "validate-build-id".
> 	* solib.h (default_solib_validate): New declaration.
> 	* solist.h (struct so_list): New fields 'build_idsz' and 'build_id'.
> 	(target_so_ops): New field 'validate'.
> 
> gdb/doc/ChangeLog
> 2015-07-15  Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
> 	* gdb.texinfo (Files): Add 'set validate-build-id'
> 	and 'show validate-build-id'.

The documentation parts are OK.

Thanks.