Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Walfred Tedeschi <walfred.tedeschi@intel.com>
Cc: palves@redhat.com, brobecker@adacore.com, gdb-patches@sourceware.org
Subject: Re: [PATCH V5 2/2] Add mpx-bnd-init-on-return set/show command for inferior calls.
Date: Fri, 18 Mar 2016 15:12:00 -0000	[thread overview]
Message-ID: <83zitv95xw.fsf@gnu.org> (raw)
In-Reply-To: <1458310577-20021-1-git-send-email-walfred.tedeschi@intel.com>	(message from Walfred Tedeschi on Fri, 18 Mar 2016 15:16:17 +0100)

> From: Walfred Tedeschi <walfred.tedeschi@intel.com>
> Cc: gdb-patches@sourceware.org, Walfred Tedeschi <walfred.tedeschi@intel.com>
> Date: Fri, 18 Mar 2016 15:16:17 +0100
> 
> diff --git a/gdb/NEWS b/gdb/NEWS
> index be15902..a123f7d 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -27,6 +27,11 @@ skip -rfunction regular-expression
>    glob-style file names and regular expressions for function names.
>    Additionally, a file spec and a function spec may now be combined.
>  
> +show mpx-bnd-init-on-return
> +set mpx-bnd-init-on-return on i386 and amd64
> +  In case MPX-BND-INIT-ON-RETURN is true, bound registers
> +  will be initialized when the "return" command is used.
> +

We don't up-case the option names in NEWS.  Also, the "on i386 and
amd64" part is not really part of the command, is it?

So I suggest the following minor change to the wording:

  show mpx-bnd-init-on-return
  set mpx-bnd-init-on-return on i386 and amd64
    On i386 and amd64, if this option is ON, bound registers
    will be re-initialized when the "return" command is used.

> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index 4ec0ec1..0e8531a 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo

This part is okay.

Thanks.


  reply	other threads:[~2016-03-18 15:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-18 14:21 Walfred Tedeschi
2016-03-18 15:12 ` Eli Zaretskii [this message]
2016-04-26 15:20 ` Yao Qi
2016-04-26 15:38   ` Walfred Tedeschi
     [not found]     ` <572749D2.5040106@intel.com>
2016-06-13 15:18       ` Tedeschi, Walfred

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83zitv95xw.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    --cc=walfred.tedeschi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox