From: Eli Zaretskii <eliz@gnu.org>
To: tromey@adacore.com
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC 8.3 0/3] Some style fixes
Date: Sun, 10 Mar 2019 13:14:00 -0000 [thread overview]
Message-ID: <83zhq26fcw.fsf@gnu.org> (raw)
In-Reply-To: <83pnr08tc8.fsf@gnu.org> (message from Eli Zaretskii on Sat, 09 Mar 2019 08:17:27 +0200)
> Date: Sat, 09 Mar 2019 08:17:27 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> CC: gdb-patches@sourceware.org
>
> > From: Tom Tromey <tromey@adacore.com>
> > Date: Fri, 8 Mar 2019 14:04:30 -0700
> >
> > This series fixes some of the TUI/styling regressions noted by Pedro.
> > I would like to push this to the 8.3 branch as well.
> >
> > Patch #2 is a new feature that Eli mentioned. Since it's an addition
> > to a feature that is also new in 8.3, it seemed reasonable to do at
> > this time.
> >
> > Let me know what you think.
>
> Thanks. I won't have time today to test the patch, but I will
> certainly try tomorrow.
Tried that now. The new "set style sources" toggle works nicely,
thanks. However, the artifacts I saw in the TUI display in the
pretest are still there. In particular, the right-hand side of the
frame of the source window still gets overwritten when stepping
through the inferior's code, and it looks like the newline is not
echoed after commands typed in the command window. E.g., here's what
I see after starting Emacs with "start -Q" and then typing "print 42":
Type "apropos word" to search for commands related to "word"...
Reading symbols from d:/usr/eli/emacs-master_2019-03-04/src/emacs.exe...
(gdb) start -QTemporary breakpoint 1 at 0x114b4b7: file emacs.c, line 839.
Starting program: d:\usr\eli\emacs-master_2019-03-04\src\emacs.exe -Q
Temporary breakpoint 1, main (argc=2, argv=0x9c11a0) at emacs.c:839
(gdb) p 42$1 = 42
As you see, the newlines after "start -Q" and "p 42" were not
output/acted upon, so the following text is displayed on the same
screen line.
Thanks.
next prev parent reply other threads:[~2019-03-10 13:14 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-08 21:04 Tom Tromey
2019-03-08 21:04 ` [RFC 8.3 2/3] Add the "set style source" command Tom Tromey
2019-03-09 6:17 ` Eli Zaretskii
2019-03-11 20:13 ` Tom Tromey
2019-03-09 11:18 ` Philippe Waroquiers
2019-03-11 20:13 ` Tom Tromey
2019-03-11 20:25 ` Eli Zaretskii
2019-03-08 21:04 ` [RFC 8.3 3/3] Avoid a crash in source_cache::extract_lines Tom Tromey
2019-03-13 17:07 ` Pedro Alves
2019-03-13 17:20 ` Tom Tromey
2019-03-13 18:06 ` Pedro Alves
2019-03-14 11:37 ` Tom Tromey
2019-03-08 21:04 ` [RFC 8.3 1/3] Make TUI react to "set style enabled" Tom Tromey
2019-03-13 19:28 ` Pedro Alves
2019-03-14 11:43 ` Tom Tromey
2019-03-09 6:17 ` [RFC 8.3 0/3] Some style fixes Eli Zaretskii
2019-03-10 13:14 ` Eli Zaretskii [this message]
2019-03-11 20:15 ` Tom Tromey
2019-03-12 16:44 ` Eli Zaretskii
2019-03-13 15:50 ` Eli Zaretskii
2019-03-14 12:21 ` Tom Tromey
2019-03-14 14:40 ` Pedro Alves
2019-03-14 15:36 ` Eli Zaretskii
2019-03-15 12:34 ` Fix pressing down in the TUI (Re: [RFC 8.3 0/3] Some style fixes) Pedro Alves
2019-03-15 13:37 ` Eli Zaretskii
2019-03-15 13:56 ` Pedro Alves
2019-03-16 17:59 ` Eli Zaretskii
2019-03-24 15:35 ` Simon Marchi
2019-03-25 1:36 ` Simon Marchi
2019-03-25 15:14 ` Tom Tromey
2019-03-26 0:52 ` Simon Marchi
2019-03-15 15:33 ` Tom Tromey
2019-03-15 12:43 ` Avoid overwriting the TUI source window frame " Pedro Alves
2019-03-16 12:17 ` Eli Zaretskii
2019-03-15 14:15 ` [PATCH v2] Fix first time you type UP or DOWN in TUI's command window " Pedro Alves
2019-03-15 15:38 ` Eli Zaretskii
2019-03-18 20:24 ` Pedro Alves
2019-03-19 6:09 ` Eli Zaretskii
2019-03-19 18:14 ` Pedro Alves
2019-03-09 14:28 ` [RFC 8.3 0/3] Some style fixes Hannes Domani via gdb-patches
2019-03-12 16:48 ` Tom Tromey
2019-03-12 17:09 ` Hannes Domani via gdb-patches
2019-03-13 15:44 ` Eli Zaretskii
2019-03-14 20:25 ` "next" into line longer than the source window-width (Re: [RFC 8.3 0/3] Some style fixes) Pedro Alves
2019-03-17 16:05 ` Eli Zaretskii
2019-03-14 20:58 ` [PATCH] Fix scrolling right in the TUI " Pedro Alves
2019-03-15 12:34 ` Hannes Domani via gdb-patches
2019-03-15 21:51 ` Tom Tromey
2019-03-18 14:41 ` Pedro Alves
2019-03-17 16:06 ` Eli Zaretskii
2019-03-12 17:29 ` [RFC 8.3 0/3] Some style fixes Eli Zaretskii
2019-03-12 17:29 ` Eli Zaretskii
2019-03-12 17:32 ` Eli Zaretskii
2019-03-26 20:52 ` Pedro Franco de Carvalho
2019-03-14 11:44 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zhq26fcw.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox