From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 35368 invoked by alias); 10 Mar 2019 13:14:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 35358 invoked by uid 89); 10 Mar 2019 13:14:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=typed, echoed, HX-Languages-Length:1647, pretest X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 10 Mar 2019 13:14:54 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47413) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2yHz-00071a-Rb; Sun, 10 Mar 2019 09:14:52 -0400 Received: from [176.228.60.248] (port=4341 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h2yHy-0001C4-2X; Sun, 10 Mar 2019 09:14:51 -0400 Date: Sun, 10 Mar 2019 13:14:00 -0000 Message-Id: <83zhq26fcw.fsf@gnu.org> From: Eli Zaretskii To: tromey@adacore.com CC: gdb-patches@sourceware.org In-reply-to: <83pnr08tc8.fsf@gnu.org> (message from Eli Zaretskii on Sat, 09 Mar 2019 08:17:27 +0200) Subject: Re: [RFC 8.3 0/3] Some style fixes References: <20190308210433.32683-1-tromey@adacore.com> <83pnr08tc8.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00220.txt.bz2 > Date: Sat, 09 Mar 2019 08:17:27 +0200 > From: Eli Zaretskii > CC: gdb-patches@sourceware.org > > > From: Tom Tromey > > Date: Fri, 8 Mar 2019 14:04:30 -0700 > > > > This series fixes some of the TUI/styling regressions noted by Pedro. > > I would like to push this to the 8.3 branch as well. > > > > Patch #2 is a new feature that Eli mentioned. Since it's an addition > > to a feature that is also new in 8.3, it seemed reasonable to do at > > this time. > > > > Let me know what you think. > > Thanks. I won't have time today to test the patch, but I will > certainly try tomorrow. Tried that now. The new "set style sources" toggle works nicely, thanks. However, the artifacts I saw in the TUI display in the pretest are still there. In particular, the right-hand side of the frame of the source window still gets overwritten when stepping through the inferior's code, and it looks like the newline is not echoed after commands typed in the command window. E.g., here's what I see after starting Emacs with "start -Q" and then typing "print 42": Type "apropos word" to search for commands related to "word"... Reading symbols from d:/usr/eli/emacs-master_2019-03-04/src/emacs.exe... (gdb) start -QTemporary breakpoint 1 at 0x114b4b7: file emacs.c, line 839. Starting program: d:\usr\eli\emacs-master_2019-03-04\src\emacs.exe -Q Temporary breakpoint 1, main (argc=2, argv=0x9c11a0) at emacs.c:839 (gdb) p 42$1 = 42 As you see, the newlines after "start -Q" and "p 42" were not output/acted upon, so the following text is displayed on the same screen line. Thanks.