Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: brobecker@adacore.com, simon.marchi@polymtl.ca
Cc: gdb-patches@sourceware.org
Subject: Re: GDB 7.99.91 MinGW compilation error in cli-script.c
Date: Fri, 19 May 2017 09:10:00 -0000	[thread overview]
Message-ID: <83y3tt2ow0.fsf@gnu.org> (raw)
In-Reply-To: <83fug35v70.fsf@gnu.org> (message from Eli Zaretskii on Wed, 17	May 2017 19:01:23 +0300)

> Date: Wed, 17 May 2017 19:01:23 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> CC: simon.marchi@polymtl.ca, gdb-patches@sourceware.org
> 
> I will probably post later a workaround patch for older versions,
> but that's for master.  I see no reason to delay the release or to
> have the fix on the branch.

Is the below OK?  It's a bit ugly, and a small fix is needed even for
the latest MinGW runtime.

Contrary to what I wrote, maybe it's also should be considered for the
branch.  Let me know what you think.

diff --git a/gdb/cli/cli-script.c b/gdb/cli/cli-script.c
index e0e27ef..ec33a37 100644
--- a/gdb/cli/cli-script.c
+++ b/gdb/cli/cli-script.c
@@ -17,6 +17,23 @@
    You should have received a copy of the GNU General Public License
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
+#if defined __MINGW32__
+#  include <_mingw.h>
+#  ifndef __MINGW64_VERSION_MAJOR
+// For versions of mingw.org's MinGW runtime before 5.0, make sure
+// libstdc++ headers don't omit portions that require C99.
+#    if __MINGW32_MAJOR_VERSION < 5
+#      ifndef _GLIBCXX_USE_C99
+#        define _GLIBCXX_USE_C99 1
+#      endif
+#    else
+// This is required with mingwrt-5.0 to avoid linking errors due to
+// multiple definitions of vsnprintf.
+#      undef __USE_MINGW_ANSI_STDIO
+#    endif
+#  endif
+#endif
+
 #include "defs.h"
 #include "value.h"
 #include "language.h"		/* For value_true */


  reply	other threads:[~2017-05-19  9:10 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-04 19:44 GDB 7.99.91 available for testing Joel Brobecker
2017-05-08 14:53 ` Eli Zaretskii
2017-05-17 11:36   ` Yao Qi
2017-05-17 14:39     ` Eli Zaretskii
2017-05-08 15:00 ` GDB 7.99.91 MinGW compilation error in cli-script.c Eli Zaretskii
2017-05-14  3:19   ` Simon Marchi
2017-05-14 14:13     ` Eli Zaretskii
2017-05-17 14:31       ` Joel Brobecker
2017-05-17 16:01         ` Eli Zaretskii
2017-05-19  9:10           ` Eli Zaretskii [this message]
2017-05-19  9:49             ` Pedro Alves
2017-05-19 11:17               ` Eli Zaretskii
2017-05-19 11:23                 ` Pedro Alves
2017-05-21 15:33                   ` Eli Zaretskii
2017-05-22 15:26                     ` Pedro Alves
2017-05-22 18:43                       ` Eli Zaretskii
2017-05-23  9:53                         ` Pedro Alves
2017-05-24  2:44                           ` Eli Zaretskii
2017-05-25 10:05                             ` Pedro Alves
2017-05-26  7:57                               ` Eli Zaretskii
2017-05-26 11:52                                 ` Pedro Alves
2017-05-26 12:57                                   ` Eli Zaretskii
2017-05-26 13:58                                     ` Pedro Alves
2017-05-24 18:28                           ` Eli Zaretskii
2017-05-24 19:37                             ` Joel Brobecker
2017-05-25 10:12                               ` Pedro Alves
2017-05-26  7:47                                 ` Eli Zaretskii
2017-05-26 10:54                                   ` Pedro Alves
2017-05-26 13:03                                     ` Eli Zaretskii
2017-05-26 14:10                                       ` Pedro Alves
2017-05-26 14:35                                         ` Eli Zaretskii
2017-05-26 14:45                                           ` Pedro Alves
2017-05-08 15:02 ` GDB 7.99.91 MinGW compilation warning in tui.c Eli Zaretskii
2017-05-09 10:17   ` Yao Qi
2017-05-13  8:12     ` Eli Zaretskii
2017-05-17 16:26       ` Yao Qi
2017-05-17 16:45         ` Eli Zaretskii
2017-05-17 18:21           ` Joel Brobecker
2017-05-19  8:02             ` Eli Zaretskii
2017-05-19  9:54               ` Pedro Alves
2017-05-19 11:14                 ` Eli Zaretskii
2017-05-19 11:25                   ` Pedro Alves
2017-05-19 12:51                     ` Eli Zaretskii
2017-05-19 13:58                       ` Pedro Alves
2017-05-19 14:40                         ` Eli Zaretskii
2017-05-19 17:50               ` DJ Delorie
2017-05-19 17:55                 ` Eli Zaretskii
2017-05-15 21:11 ` GDB 7.99.91 available for testing Simon Marchi
2017-05-16 13:51   ` Simon Marchi
2017-05-16 20:50     ` Yao Qi
2017-05-16 21:22       ` Simon Marchi
2017-05-16 21:40         ` Yao Qi
2017-05-17 11:31           ` [PATCH master/8.0] Add alias command to cmd_list_element Yao Qi
2017-05-17 12:16             ` Simon Marchi
2017-05-17 13:36               ` Yao Qi
2017-05-16 14:28   ` GDB 7.99.91 available for testing Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83y3tt2ow0.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox