From: Eli Zaretskii <eliz@gnu.org>
To: Philippe Waroquiers <philippe.waroquiers@skynet.be>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA 3/3] NEWS and documentation for $_gdb_setting and $_gdb_int_setting.
Date: Sun, 28 Apr 2019 16:17:00 -0000 [thread overview]
Message-ID: <83y33ut88c.fsf@gnu.org> (raw)
In-Reply-To: <20190428151816.31598-4-philippe.waroquiers@skynet.be> (message from Philippe Waroquiers on Sun, 28 Apr 2019 17:18:16 +0200)
> From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
> Cc: Philippe Waroquiers <philippe.waroquiers@skynet.be>
> Date: Sun, 28 Apr 2019 17:18:16 +0200
>
> +* New built-in convenience functions $_gdb_setting and $_gdb_int_setting
> + provide access to the value of the GDB settings. They are handy
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
"provide access to values of ..."
> +@findex $_gdb_setting@r{, convenience function}
> +Return the value of the @value{GDBN} @var{setting} as a string value.
^^^^^^^^^^^^^^^^^
"as a string", the "value" part is redundant.
> +@var{setting} argument is the suffix to use in the @code{show} command
I'd drop the "argument" part.
I also think that "suffix to use in the 'show' command" is a
potentially confusing description. How about
@var{setting} is any setting that can be used in a @code{set} or
@code{show} command (@pxref{Controlling GDB}).
> +@item $_gdb_int_setting (@var{setting})
> +@findex $_gdb_int_setting@r{, convenience function}
> +Return the value of the @value{GDBN} @var{setting} as an integer value.
^^^^^^^^^^^^^^^^
Again, I'd drop the "value" part.
> +This only works for boolean, auto boolean and integer settings.
> +The boolean values @code{false} and @code{true} are converted to
> +the integer values @code{0} and @code{1}. The value @code{auto} is
^^
Two spaces.
> +converted to the value @code{2}.
What about the value "infinite" or "unlimited"?
Thanks.
next prev parent reply other threads:[~2019-04-28 16:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-28 15:18 [RFA 0/3] Convenience functions $_gdb_setting/$_gdb_int_setting Philippe Waroquiers
2019-04-28 15:18 ` [RFA 1/3] Implement convenience functions to examine GDB settings Philippe Waroquiers
2019-04-28 15:18 ` [RFA 3/3] NEWS and documentation for $_gdb_setting and $_gdb_int_setting Philippe Waroquiers
2019-04-28 16:17 ` Eli Zaretskii [this message]
2019-04-28 15:18 ` [RFA 2/3] Test the convenience functions " Philippe Waroquiers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y33ut88c.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=philippe.waroquiers@skynet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox