From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-155710-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 15175 invoked by alias); 28 Apr 2019 16:17:43 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 15167 invoked by uid 89); 28 Apr 2019 16:17:43 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-5.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,SPF_PASS autolearn=ham version=3.3.1 spammy=pxref, @pxref
X-HELO: eggs.gnu.org
Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 28 Apr 2019 16:17:42 +0000
Received: from fencepost.gnu.org ([2001:470:142:3::e]:38000)	by eggs.gnu.org with esmtp (Exim 4.71)	(envelope-from <eliz@gnu.org>)	id 1hKmUh-0007iw-Q8; Sun, 28 Apr 2019 12:17:39 -0400
Received: from [176.228.60.248] (port=4221 helo=home-c4e4a596f7)	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)	(Exim 4.82)	(envelope-from <eliz@gnu.org>)	id 1hKmUh-0003qr-3R; Sun, 28 Apr 2019 12:17:35 -0400
Date: Sun, 28 Apr 2019 16:17:00 -0000
Message-Id: <83y33ut88c.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Philippe Waroquiers <philippe.waroquiers@skynet.be>
CC: gdb-patches@sourceware.org
In-reply-to: <20190428151816.31598-4-philippe.waroquiers@skynet.be> (message	from Philippe Waroquiers on Sun, 28 Apr 2019 17:18:16 +0200)
Subject: Re: [RFA 3/3] NEWS and documentation for $_gdb_setting and $_gdb_int_setting.
References: <20190428151816.31598-1-philippe.waroquiers@skynet.be> <20190428151816.31598-4-philippe.waroquiers@skynet.be>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-IsSubscribed: yes
X-SW-Source: 2019-04/txt/msg00615.txt.bz2

> From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
> Cc: Philippe Waroquiers <philippe.waroquiers@skynet.be>
> Date: Sun, 28 Apr 2019 17:18:16 +0200
> 
> +* New built-in convenience functions $_gdb_setting and $_gdb_int_setting
> +  provide access to the value of the GDB settings.  They are handy
     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
"provide access to values of ..."

> +@findex $_gdb_setting@r{, convenience function}
> +Return the value of the @value{GDBN} @var{setting} as a string value.
                                                      ^^^^^^^^^^^^^^^^^
"as a string", the "value" part is redundant.

> +@var{setting} argument is the suffix to use in the @code{show} command

I'd drop the "argument" part.

I also think that "suffix to use in the 'show' command" is a
potentially confusing description.  How about

  @var{setting} is any setting that can be used in a @code{set} or
  @code{show} command (@pxref{Controlling GDB}).

> +@item $_gdb_int_setting (@var{setting})
> +@findex $_gdb_int_setting@r{, convenience function}
> +Return the value of the @value{GDBN} @var{setting} as an integer value.
                                                         ^^^^^^^^^^^^^^^^
Again, I'd drop the "value" part.

> +This only works for boolean, auto boolean and integer settings.
> +The boolean values @code{false} and @code{true} are converted to
> +the integer values @code{0} and @code{1}. The value @code{auto} is
                                           ^^
Two spaces.

> +converted to the value  @code{2}.

What about the value "infinite" or "unlimited"?

Thanks.