Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tromey@redhat.com>
Cc: sergiodj@linux.vnet.ibm.com, gdb-patches@sourceware.org
Subject: Re: [PATCH 0/3] catch syscall -- try 5 -- Introduction
Date: Fri, 24 Apr 2009 13:47:00 -0000	[thread overview]
Message-ID: <83ws9af9k9.fsf@gnu.org> (raw)
In-Reply-To: <m3hc0fqcwu.fsf@fleche.redhat.com>

> Cc: gdb-patches@sourceware.org
> From: Tom Tromey <tromey@redhat.com>
> Date: Thu, 23 Apr 2009 15:26:57 -0600
> 
> +  add_setshow_filename_cmd ("data-directory", class_maintenance,
> +                           &gdb_datadir, _("Set GDB's data directory."),
> +                           _("Show GDB's data directory."),
> +                           _("\
> +When set, GDB uses the specified path to search for data files."),
> +                           NULL, NULL,
> +                           &setlist,
> +                           &showlist);
>  }

I would suggest to add another sentence with a few examples of which
data files will be looked up in that directory.  Also, since this is a
directory (as opposed to a search path), let's not use "path" in the
doc string.

> +* Data Files::                  GDB data files

This section is not about data files, it's about where GDB finds them.
So I suggest to change the text to the right of the menu item to
"Where @value{GDBN} looks for its data files."

> +@section GDB Data Files
            ^^^
"@value{GDBN}"

> +@cindex prefix for data files
> +@value{GDBN} will sometimes read an auxiliary data file.  These files
> +are kept in a directory known as the @dfn{data directory}.

As in the doc string (and for the manual this is even more important),
I think we should tell here what files are looked up there.

Otherwise, the patch for the manual is fine.

Thanks.


  reply	other threads:[~2009-04-24 13:47 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-23  0:33 Sérgio Durigan Júnior
2009-04-23  1:18 ` Tom Tromey
2009-04-23  2:29   ` Sérgio Durigan Júnior
2009-04-23 18:23     ` Tom Tromey
2009-04-23 21:27       ` Tom Tromey
2009-04-24 13:47         ` Eli Zaretskii [this message]
2009-04-23 11:49 ` Hui Zhu
2009-04-23 15:16   ` Sérgio Durigan Júnior
2009-04-23 15:28     ` Hui Zhu
2009-04-23 15:52       ` Sérgio Durigan Júnior
2009-05-07  3:22 ` Hui Zhu
2009-05-08  1:23   ` Sérgio Durigan Júnior
2009-05-29 20:34     ` Sérgio Durigan Júnior
2009-06-29  2:15       ` Hui Zhu
2009-06-29 15:30         ` Tom Tromey
2009-05-17 20:43 ` Sérgio Durigan Júnior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83ws9af9k9.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=sergiodj@linux.vnet.ibm.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox