From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-63296-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 28235 invoked by alias); 24 Apr 2009 13:47:18 -0000
Received: (qmail 28225 invoked by uid 22791); 24 Apr 2009 13:47:16 -0000
X-SWARE-Spam-Status: No, hits=1.4 required=5.0 	tests=AWL,BAYES_00,BOTNET,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout1.012.net.il (HELO mtaout1.012.net.il) (84.95.2.1)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 24 Apr 2009 13:47:08 +0000
Received: from conversion-daemon.i-mtaout1.012.net.il by i-mtaout1.012.net.il (HyperSendmail v2007.08) id <0KIL00G00Y6WBI00@i-mtaout1.012.net.il> for gdb-patches@sourceware.org; Fri, 24 Apr 2009 16:47:04 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([77.127.175.232]) by i-mtaout1.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KIL000M9YADNKD0@i-mtaout1.012.net.il>; Fri, 24 Apr 2009 16:47:04 +0300 (IDT)
Date: Fri, 24 Apr 2009 13:47:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH 0/3] catch syscall -- try 5 -- Introduction
In-reply-to: <m3hc0fqcwu.fsf@fleche.redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: sergiodj@linux.vnet.ibm.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83ws9af9k9.fsf@gnu.org>
References: <1240446781.2000.82.camel@miki> <m3d4b4rwuj.fsf@fleche.redhat.com> <1240453740.2000.90.camel@miki> <m3tz4fqlf5.fsf@fleche.redhat.com> <m3hc0fqcwu.fsf@fleche.redhat.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-04/txt/msg00690.txt.bz2

> Cc: gdb-patches@sourceware.org
> From: Tom Tromey <tromey@redhat.com>
> Date: Thu, 23 Apr 2009 15:26:57 -0600
> 
> +  add_setshow_filename_cmd ("data-directory", class_maintenance,
> +                           &gdb_datadir, _("Set GDB's data directory."),
> +                           _("Show GDB's data directory."),
> +                           _("\
> +When set, GDB uses the specified path to search for data files."),
> +                           NULL, NULL,
> +                           &setlist,
> +                           &showlist);
>  }

I would suggest to add another sentence with a few examples of which
data files will be looked up in that directory.  Also, since this is a
directory (as opposed to a search path), let's not use "path" in the
doc string.

> +* Data Files::                  GDB data files

This section is not about data files, it's about where GDB finds them.
So I suggest to change the text to the right of the menu item to
"Where @value{GDBN} looks for its data files."

> +@section GDB Data Files
            ^^^
"@value{GDBN}"

> +@cindex prefix for data files
> +@value{GDBN} will sometimes read an auxiliary data file.  These files
> +are kept in a directory known as the @dfn{data directory}.

As in the doc string (and for the manual this is even more important),
I think we should tell here what files are looked up there.

Otherwise, the patch for the manual is fine.

Thanks.