Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: vapier@gentoo.org, gdb-patches@sourceware.org
Subject: Re: [PATCH] sim: add more hacking notes
Date: Mon, 12 Apr 2010 17:36:00 -0000	[thread overview]
Message-ID: <83wrwcy3mu.fsf@gnu.org> (raw)
In-Reply-To: <20100412145619.GT19194@adacore.com>

> Date: Mon, 12 Apr 2010 07:56:19 -0700
> From: Joel Brobecker <brobecker@adacore.com>
> Cc: gdb-patches@sourceware.org
> 
> > 2010-04-10  Mike Frysinger  <vapier@gentoo.org>
> > 
> > 	* README-HACKING: Add more sections.
> > 
> 
> This one might be more in Eli's department than anyone else. If not,
> I'll be happy to review....

This isn't user-visible docs, so all I did was proofread it.  I have
only a couple of comments:

> > +Hardware devices typically attach address ranges to themselves.  Then when
> > +a accesses to those addresses are made, the hardware will have its callback
     ^
This "a" is redundant.

> > +   any mix of input and output ports are allowed.
                                          ^^^^^^^^^^^
"is allowed"

Thanks.


  reply	other threads:[~2010-04-12 17:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-10 18:58 Mike Frysinger
2010-04-12 14:56 ` Joel Brobecker
2010-04-12 17:36   ` Eli Zaretskii [this message]
2010-04-12 18:12     ` Mike Frysinger
2010-04-12 18:26       ` Eli Zaretskii
2010-04-12 19:57         ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83wrwcy3mu.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox