From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-72051-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 27118 invoked by alias); 12 Apr 2010 17:36:30 -0000
Received: (qmail 27103 invoked by uid 22791); 12 Apr 2010 17:36:29 -0000
X-SWARE-Spam-Status: No, hits=-1.2 required=5.0 	tests=BAYES_00,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 12 Apr 2010 17:36:22 +0000
Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0L0R00900Y8HC100@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Mon, 12 Apr 2010 20:36:19 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([77.127.74.198]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L0R008BOY8I6440@a-mtaout20.012.net.il>; Mon, 12 Apr 2010 20:36:19 +0300 (IDT)
Date: Mon, 12 Apr 2010 17:36:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH] sim: add more hacking notes
In-reply-to: <20100412145619.GT19194@adacore.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: vapier@gentoo.org, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83wrwcy3mu.fsf@gnu.org>
References: <1270925910-23834-1-git-send-email-vapier@gentoo.org> <20100412145619.GT19194@adacore.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-04/txt/msg00370.txt.bz2

> Date: Mon, 12 Apr 2010 07:56:19 -0700
> From: Joel Brobecker <brobecker@adacore.com>
> Cc: gdb-patches@sourceware.org
> 
> > 2010-04-10  Mike Frysinger  <vapier@gentoo.org>
> > 
> > 	* README-HACKING: Add more sections.
> > 
> 
> This one might be more in Eli's department than anyone else. If not,
> I'll be happy to review....

This isn't user-visible docs, so all I did was proofread it.  I have
only a couple of comments:

> > +Hardware devices typically attach address ranges to themselves.  Then when
> > +a accesses to those addresses are made, the hardware will have its callback
     ^
This "a" is redundant.

> > +   any mix of input and output ports are allowed.
                                          ^^^^^^^^^^^
"is allowed"

Thanks.