From: Eli Zaretskii <eliz@gnu.org>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [python][patch] Add GDB Parameters functionality
Date: Tue, 27 Apr 2010 17:45:00 -0000 [thread overview]
Message-ID: <83wrvsyelz.fsf@gnu.org> (raw)
In-Reply-To: <4BD6D7C7.9040804@redhat.com>
> Date: Mon, 26 Apr 2010 14:19:21 +0100
> From: Phil Muldoon <pmuldoon@redhat.com>
>
> Thanks, I've made the changes. I would like you to have another look
> at them.
See below.
> > Maybe we should consider mentioning this in NEWS.
>
>
> I thought I attached this to the original patch.
Indeed, you did. Sorry that I missed it. It is okay.
> +Parameters are exposed to the user via the @code{set} and
> +@code{show} commands. @xref{Help}.
^^
Two spaces, please.
> +@item PARAM_STRING
> +The value is a string. When the user modifies the string, any escapes
> +sequences are translated and encoded by @value{GDBN}.
I asked to say something about this translation, or provide an
example.
> +@item PARAM_FILENAME
> +The value is a filename (a string). This value is has to be a valid
> +filename. ^^
The "is" part is probably redundant. Also, what does it mean "a valid
filename"? Does it have to exist, for example? If not, what makes a
file name "invalid"?
Thanks.
next prev parent reply other threads:[~2010-04-27 17:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-26 13:19 Phil Muldoon
2010-04-26 17:56 ` Eli Zaretskii
2010-04-27 12:26 ` Phil Muldoon
2010-04-27 17:45 ` Eli Zaretskii [this message]
2010-04-27 19:25 ` Phil Muldoon
2010-04-27 19:36 ` Eli Zaretskii
2010-04-27 20:05 ` Phil Muldoon
2010-04-28 2:59 ` Eli Zaretskii
2010-04-28 6:28 ` Phil Muldoon
2010-04-28 9:18 ` Phil Muldoon
2010-04-28 17:15 ` Eli Zaretskii
2010-04-28 20:31 ` Phil Muldoon
2010-04-29 3:06 ` Eli Zaretskii
2010-04-29 16:13 ` Phil Muldoon
2010-04-26 21:45 ` Tom Tromey
2010-04-26 21:52 ` Phil Muldoon
2010-04-27 3:09 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83wrvsyelz.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=pmuldoon@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox