From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-72596-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 29059 invoked by alias); 27 Apr 2010 17:45:04 -0000
Received: (qmail 28991 invoked by uid 22791); 27 Apr 2010 17:45:02 -0000
X-SWARE-Spam-Status: No, hits=-1.2 required=5.0 	tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 27 Apr 2010 17:44:58 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0L1J00F00QEFWE00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Tue, 27 Apr 2010 20:44:44 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([77.127.125.239]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L1J00BUVQMC0SC0@a-mtaout22.012.net.il>; Tue, 27 Apr 2010 20:44:44 +0300 (IDT)
Date: Tue, 27 Apr 2010 17:45:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [python][patch] Add GDB Parameters functionality
In-reply-to: <4BD6D7C7.9040804@redhat.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83wrvsyelz.fsf@gnu.org>
References: <4BD592D9.1070801@redhat.com> <838w8ayu7a.fsf@gnu.org> <4BD6D7C7.9040804@redhat.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-04/txt/msg00915.txt.bz2

> Date: Mon, 26 Apr 2010 14:19:21 +0100
> From: Phil Muldoon <pmuldoon@redhat.com>
> 
> Thanks, I've made the changes.  I would like you to have another look
> at them.

See below.

> > Maybe we should consider mentioning this in NEWS.
> 
> 
> I thought I attached this to the original patch.

Indeed, you did.  Sorry that I missed it.  It is okay.

> +Parameters are exposed to the user via the @code{set} and
> +@code{show} commands. @xref{Help}.
                       ^^
Two spaces, please.

> +@item PARAM_STRING
> +The value is a string.  When the user modifies the string, any escapes
> +sequences are translated and encoded by @value{GDBN}.

I asked to say something about this translation, or provide an
example.

> +@item PARAM_FILENAME
> +The value is a filename (a string).  This value is has to be a valid
> +filename.                                       ^^

The "is" part is probably redundant.  Also, what does it mean "a valid
filename"?  Does it have to exist, for example?  If not, what makes a
file name "invalid"?

Thanks.