Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFA: manual updates for c++
Date: Fri, 11 Nov 2011 15:47:00 -0000	[thread overview]
Message-ID: <83wrb6fyt3.fsf@gnu.org> (raw)
In-Reply-To: <m3lirmu2ku.fsf@fleche.redhat.com>

> From: Tom Tromey <tromey@redhat.com>
> Cc: gdb-patches@sourceware.org
> Date: Fri, 11 Nov 2011 08:00:01 -0700
> 
> -gstabs+ ... I don't know as much about stabs.  My impression is that
> they don't handle C++ very well.  Certainly on the GCC side nobody puts
> any work into them at all, and very little work in GDB.

Maybe we should tell that stabs doesn't work well with C++, then.

> >> +                                               Starting with version
> >> +4.7, @value{NGCC} can emit macro information in a more compact format.
> 
> Eli> Why is this part important to a GDB user?
> 
> A previous sentence mentions that the information is large.  Assuming
> that this earlier sentence provides any value to the GDB user,
> mentioning that the problem can be ameliorated also seems appropriate.

If you think it's important.  It reads as if it isn't.  How about
removing that sentence about large information instead?

Another nit:

> +Now, we compile the program using the @sc{gnu} C compiler,
> +@value{NGCC}.  We pass the @option{-gdwarf-2} @footnote{This is the
> +minimum.  Recent versions of @value{NGCC} support @option{-gdwarf-3}
> +@option{-gdwarf-4}; we recommend always choosing the most recent
> +version of DWARF} AND @option{-g3} flags to ensure the compiler

The last sentence in the @footnote doesn't have a period after it.
Also the @footnote should immediately follow the character after which
you want to see the footnote number in print, without any whitespace.
Finally, the "AND" part will look better in print if you use @strong
or @emph markup.

Sorry I didn't see that before.

Thanks.


  reply	other threads:[~2011-11-11 15:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-10 18:45 Tom Tromey
2011-11-11  8:27 ` Eli Zaretskii
2011-11-11 15:00   ` Tom Tromey
2011-11-11 15:47     ` Eli Zaretskii [this message]
2011-11-11 16:27       ` Tom Tromey
2011-11-11 16:51         ` Eli Zaretskii
2011-11-27 20:46     ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83wrb6fyt3.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox