From: Eli Zaretskii <eliz@gnu.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/commit+doco] GDB/MI: Document support for -exec-run --start in -list-features
Date: Tue, 03 Dec 2013 07:22:00 -0000 [thread overview]
Message-ID: <83wqjm4cwl.fsf@gnu.org> (raw)
In-Reply-To: <1386051670-28637-1-git-send-email-brobecker@adacore.com>
> From: Joel Brobecker <brobecker@adacore.com>
> Date: Tue, 3 Dec 2013 10:21:10 +0400
>
> While reviewing all the changes I made for GDB/MI, recently, and making
> sure that every new features should be check-able before use, I noticed
> that were were missing a way to test if --exec-run supports --start.
>
> This adds "exec-run-start-option" in the output of the -list-features
> commands, allowing front-ends to easily determine whether -exec-run
> supports the --start option.
>
> gdb/ChangeLog:
>
> * mi/mi-main.c (mi_cmd_list_features): add "exec-run-start-option".
> * NEWS: Expand the entry documenting the new -exec-run --start
> option to mention the corresponding new entry in the output of
> "-list-features".
>
> gdb/doc/ChangeLog:
>
> * gdb.texinfo (GDB/MI Miscellaneous Commands): Document the new
> "exec-run-start-option" entry in the output of the "-list-features"
> command.
>
> gdb/testsuite/ChangeLog:
>
> * gdb.mi/mi-start.exp: Add test verifying that -list-features
> contains "exec-run-start-option".
>
> Tested on x86_64-linux. Both code and doco parts are relatively
> straightforward, so I am planning on checking this in in a day or
> two, assuming doco approval.
You have my approval, with one comment: each one of the items in that
@table in gdb.texinfo should be indexed, to facilitate their
discoverability by readers. E.g., for this item I'd suggest
@findex exec-run-start-option
@cindex support for @option{--start} option in @code{-exec-run}
I'd also add an index entry for the entire section
@cindex supported @sc{gdb/mi} features, list
From the past couple of weeks, it sounds like this section will grow
very fast (so maybe it should become a full-fledged @node).
Thanks.
next prev parent reply other threads:[~2013-12-03 7:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 6:21 Joel Brobecker
2013-12-03 7:22 ` Eli Zaretskii [this message]
2013-12-03 10:18 ` Joel Brobecker
2013-12-10 12:03 ` Joel Brobecker
2013-12-10 17:39 ` Eli Zaretskii
2013-12-12 16:02 ` pushed: Add @cindex for section documenting the -list-features GDB/MI command. (was: "[RFA/commit+doco] GDB/MI: Document support for -exec-run --start in -list-features") Joel Brobecker
2013-12-12 16:35 ` Eli Zaretskii
2013-12-13 6:10 ` [RFA/commit+doco] GDB/MI: Document support for -exec-run --start in -list-features Joel Brobecker
2013-12-13 15:51 ` Joel Brobecker
2013-12-13 19:36 ` Eli Zaretskii
2013-12-23 1:01 ` Joel Brobecker
2013-12-23 1:40 ` Joel Brobecker
2013-12-23 3:49 ` Eli Zaretskii
2013-12-23 4:28 ` Joel Brobecker
2013-12-23 16:10 ` Eli Zaretskii
2013-12-28 3:10 ` pushed: " Joel Brobecker
2013-12-10 11:14 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83wqjm4cwl.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox