From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26063 invoked by alias); 3 Dec 2013 07:22:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26052 invoked by uid 89); 3 Dec 2013 07:22:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,SPF_SOFTFAIL,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mtaout21.012.net.il Received: from Unknown (HELO mtaout21.012.net.il) (80.179.55.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Dec 2013 07:22:25 +0000 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0MX700I00Z4XWI00@a-mtaout21.012.net.il> for gdb-patches@sourceware.org; Tue, 03 Dec 2013 09:22:17 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MX700IHZZ54KKB0@a-mtaout21.012.net.il>; Tue, 03 Dec 2013 09:22:16 +0200 (IST) Date: Tue, 03 Dec 2013 07:22:00 -0000 From: Eli Zaretskii Subject: Re: [RFA/commit+doco] GDB/MI: Document support for -exec-run --start in -list-features In-reply-to: <1386051670-28637-1-git-send-email-brobecker@adacore.com> To: Joel Brobecker Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83wqjm4cwl.fsf@gnu.org> References: <1386051670-28637-1-git-send-email-brobecker@adacore.com> X-IsSubscribed: yes X-SW-Source: 2013-12/txt/msg00066.txt.bz2 > From: Joel Brobecker > Date: Tue, 3 Dec 2013 10:21:10 +0400 > > While reviewing all the changes I made for GDB/MI, recently, and making > sure that every new features should be check-able before use, I noticed > that were were missing a way to test if --exec-run supports --start. > > This adds "exec-run-start-option" in the output of the -list-features > commands, allowing front-ends to easily determine whether -exec-run > supports the --start option. > > gdb/ChangeLog: > > * mi/mi-main.c (mi_cmd_list_features): add "exec-run-start-option". > * NEWS: Expand the entry documenting the new -exec-run --start > option to mention the corresponding new entry in the output of > "-list-features". > > gdb/doc/ChangeLog: > > * gdb.texinfo (GDB/MI Miscellaneous Commands): Document the new > "exec-run-start-option" entry in the output of the "-list-features" > command. > > gdb/testsuite/ChangeLog: > > * gdb.mi/mi-start.exp: Add test verifying that -list-features > contains "exec-run-start-option". > > Tested on x86_64-linux. Both code and doco parts are relatively > straightforward, so I am planning on checking this in in a day or > two, assuming doco approval. You have my approval, with one comment: each one of the items in that @table in gdb.texinfo should be indexed, to facilitate their discoverability by readers. E.g., for this item I'd suggest @findex exec-run-start-option @cindex support for @option{--start} option in @code{-exec-run} I'd also add an index entry for the entire section @cindex supported @sc{gdb/mi} features, list >From the past couple of weeks, it sounds like this section will grow very fast (so maybe it should become a full-fledged @node). Thanks.