From: Eli Zaretskii <eliz@gnu.org>
To: Siva Chandra <sivachandra@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC/Patch v3] PR 16113: Allow gdb.Field objects as subscripts on gdb.Value objects
Date: Thu, 12 Dec 2013 20:12:00 -0000 [thread overview]
Message-ID: <83wqj96d8s.fsf@gnu.org> (raw)
In-Reply-To: <CAGyQ6gyj2rJqpZmNwSpfNiCovAEf6_P_gZvhs8iyf1-DOEOGbQ@mail.gmail.com>
> Date: Wed, 11 Dec 2013 15:23:36 -0800
> From: Siva Chandra <sivachandra@google.com>
>
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -40,6 +40,8 @@
> ** Frame filters and frame decorators have been added.
> ** Temporary breakpoints are now supported.
> ** Line tables representation has been added.
> + ** New attribute 'parent_type' for gdb.Field objects.
> + ** gdb.Field objects can be used as subscripts on gdb.Value objects.
OK.
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -23985,7 +23985,17 @@ can access its @code{foo} element with:
> bar = some_val['foo']
> @end smallexample
>
> -Again, @code{bar} will also be a @code{gdb.Value} object.
> +@cindex getting structure elements using gdb.Field objects as subscripts
> +Again, @code{bar} will also be a @code{gdb.Value} object. Structure
> +elements can also be accessed by using @code{gdb.Field} objects as
> +subscripts (@xref{Types In Python} for more information on
^
Please use @pxref here, and add a comma after the closing brace, as
indicated. Cross-references should have a comma, a period, or (in the
case of @pxref) a closing parenthesis after their closing brace.
OK with that change.
Thanks.
prev parent reply other threads:[~2013-12-12 20:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 23:23 Siva Chandra
2013-12-12 2:36 ` Tom Tromey
2013-12-12 19:36 ` Siva Chandra
2013-12-12 20:11 ` Eli Zaretskii
2013-12-12 20:12 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83wqj96d8s.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=sivachandra@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox