From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-108311-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 31568 invoked by alias); 12 Dec 2013 20:12:06 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 31550 invoked by uid 89); 12 Dec 2013 20:12:05 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout22.012.net.il
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 12 Dec 2013 20:12:05 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MXP00600MCQHZ00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Thu, 12 Dec 2013 22:11:32 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MXP006LUMR6D360@a-mtaout22.012.net.il>; Thu, 12 Dec 2013 22:11:30 +0200 (IST)
Date: Thu, 12 Dec 2013 20:12:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFC/Patch v3] PR 16113: Allow gdb.Field objects as subscripts on gdb.Value objects
In-reply-to: <CAGyQ6gyj2rJqpZmNwSpfNiCovAEf6_P_gZvhs8iyf1-DOEOGbQ@mail.gmail.com>
To: Siva Chandra <sivachandra@google.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83wqj96d8s.fsf@gnu.org>
References: <CAGyQ6gyj2rJqpZmNwSpfNiCovAEf6_P_gZvhs8iyf1-DOEOGbQ@mail.gmail.com>
X-IsSubscribed: yes
X-SW-Source: 2013-12/txt/msg00515.txt.bz2

> Date: Wed, 11 Dec 2013 15:23:36 -0800
> From: Siva Chandra <sivachandra@google.com>
> 
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -40,6 +40,8 @@
>    ** Frame filters and frame decorators have been added.
>    ** Temporary breakpoints are now supported.
>    ** Line tables representation has been added.
> +  ** New attribute 'parent_type' for gdb.Field objects.
> +  ** gdb.Field objects can be used as subscripts on gdb.Value objects.

OK.

> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -23985,7 +23985,17 @@ can access its @code{foo} element with:
>  bar = some_val['foo']
>  @end smallexample
>  
> -Again, @code{bar} will also be a @code{gdb.Value} object.
> +@cindex getting structure elements using gdb.Field objects as subscripts
> +Again, @code{bar} will also be a @code{gdb.Value} object.  Structure
> +elements can also be accessed by using @code{gdb.Field} objects as
> +subscripts (@xref{Types In Python} for more information on
                                     ^
Please use @pxref here, and add a comma after the closing brace, as
indicated.  Cross-references should have a comma, a period, or (in the
case of @pxref) a closing parenthesis after their closing brace.

OK with that change.

Thanks.