Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: will.newton@linaro.org, ricard.wanderlof@axis.com,
	gdb-patches@sourceware.org
Subject: Re: reject merges on gdb release branches?
Date: Fri, 24 Jan 2014 14:27:00 -0000	[thread overview]
Message-ID: <83wqhpcv4z.fsf@gnu.org> (raw)
In-Reply-To: <20140124115548.GO4762@adacore.com>

[Resending because the list rejected the attachment.]

> Date: Fri, 24 Jan 2014 15:55:48 +0400
> From: Joel Brobecker <brobecker@adacore.com>
> Cc: will.newton@linaro.org, ricard.wanderlof@axis.com,	gdb-patches@sourceware.org
> 
> > I'm not talking about review: for review we send and receive diffs,
> > not commits with their metadata.  I'm talking about the history DAG
> > after the commit and the push.  And, as you well know, a merge that
> > causes conflicts requires a commit after resolving those conflicts.
> 
> I don't understand what you mean, anymore.

Sorry about that.  What I meant to say was that the merge vs rebase
issue is not relevant to patch review.

> > > Sure. Attached is a gittk screenshot.
> > 
> > And what exactly are the difficulties with that?
> 
> I can guaranty you that most people will find this non-linear history
> at best hard to follow, at worst plain confusing. I consider myself
> relatively well versed in git, and yet I consider this type of history
> to be fairly hard to follow. While you do not seem to have trouble
> with it, you have to think about the others.

In Emacs development, we don't have any trouble with even more
complicated DAG structures.  See the attached for a (relatively
simple) example.

> We'll have to agree to disagree, then (and I use merges routinely,
> so I think I also have a good handle on them). The problem I have
> with your request is that we're trading a one-off operation (merge
> vs rebase) against a history that is necessarily more complicated.
> And most, if not all people who expressed an opinion, confirmed that.

Why does this issue have to be decided by a majority?


  reply	other threads:[~2014-01-24 14:27 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-22  5:11 Joel Brobecker
2014-01-22  5:22 ` Doug Evans
2014-01-22  5:48 ` Yao Qi
2014-01-22  7:37   ` Joel Brobecker
2014-01-22 12:45     ` Yao Qi
2014-01-22 12:37 ` Pedro Alves
2014-01-22 15:35 ` Eli Zaretskii
2014-01-22 16:15   ` Joel Brobecker
2014-01-22 16:23     ` H.J. Lu
2014-01-22 16:39     ` Eli Zaretskii
2014-01-23  7:46       ` Ricard Wanderlof
2014-01-23 16:17         ` Eli Zaretskii
2014-01-24  7:36           ` Ricard Wanderlof
2014-01-24  7:56             ` Eli Zaretskii
2014-01-24  8:07               ` Doug Evans
2014-01-24  8:38                 ` Eli Zaretskii
2014-01-24  8:07               ` Joel Brobecker
2014-01-24  8:54                 ` Eli Zaretskii
2014-01-24 10:09                   ` Will Newton
2014-01-24 10:28                     ` Eli Zaretskii
2014-01-24 10:35                       ` Will Newton
2014-01-24 10:48                         ` Eli Zaretskii
2014-01-24 10:58                           ` Joel Brobecker
2014-01-24 11:11                             ` Eli Zaretskii
     [not found]                               ` <20140124113014.GN4762@adacore.com>
2014-01-24 11:38                                 ` Joel Brobecker
2014-01-24 11:39                                 ` Eli Zaretskii
2014-01-24 11:55                                   ` Joel Brobecker
2014-01-24 14:27                                     ` Eli Zaretskii [this message]
2014-01-24 14:45                                       ` H.J. Lu
2014-01-24 15:44                                         ` Eli Zaretskii
2014-01-24 15:49                                           ` H.J. Lu
2014-01-24 16:02                                             ` Eli Zaretskii
2014-01-24 16:05                                               ` H.J. Lu
2014-01-24 16:18                                             ` Andreas Schwab
2014-01-22 16:07 ` Tom Tromey
2014-01-23  5:58 ` Joel Brobecker
2014-01-23 15:35   ` Tom Tromey
2014-01-24  2:18     ` Joel Brobecker
2014-01-24  3:06       ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83wqhpcv4z.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=ricard.wanderlof@axis.com \
    --cc=will.newton@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox