From: Joel Brobecker <brobecker@adacore.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: reject merges on gdb release branches?
Date: Wed, 22 Jan 2014 07:37:00 -0000 [thread overview]
Message-ID: <20140122073709.GE4762@adacore.com> (raw)
In-Reply-To: <52DF5B39.1020209@codesourcery.com>
> > I propose we do the same for the gdb-7.7 branch, and generally
> > speaking on all GDB release branches, just to make sure that
> > people don't accidently push a merge when they meant to cherry-pick.
> > Thoughts?
>
> My git knowledge is too poor to understand this. How does people push
> a merge? My workflow is to cherry-pick approved patches from one branch
> to master, and git push. I thought that is the only way to push
> commits to master. Am I missing something?
You are doing thing correctly. Another way to do things, if you have
a large number of commits to push, is to "git rebase your-branch master;
git checkout master; git merge your-branch", which should result in
a "fast-forward merge" (which is actually not technically a merge).
For more info, I really recommend you read a book such as "Pro Git",
as understanding the models behind git is a worthwhile investment.
The purpose of this proposal is to make sure that people don't do
"git merge my-commit-on-master" and push that to the release branch.
This would have catastrophic consequences, as it would bring into
the branch all commits on master since we created the release branch.
Not what the contributor wanted, but very easy to do if you don't
know git well enough.
--
Joel
next prev parent reply other threads:[~2014-01-22 7:37 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-22 5:11 Joel Brobecker
2014-01-22 5:22 ` Doug Evans
2014-01-22 5:48 ` Yao Qi
2014-01-22 7:37 ` Joel Brobecker [this message]
2014-01-22 12:45 ` Yao Qi
2014-01-22 12:37 ` Pedro Alves
2014-01-22 15:35 ` Eli Zaretskii
2014-01-22 16:15 ` Joel Brobecker
2014-01-22 16:23 ` H.J. Lu
2014-01-22 16:39 ` Eli Zaretskii
2014-01-23 7:46 ` Ricard Wanderlof
2014-01-23 16:17 ` Eli Zaretskii
2014-01-24 7:36 ` Ricard Wanderlof
2014-01-24 7:56 ` Eli Zaretskii
2014-01-24 8:07 ` Joel Brobecker
2014-01-24 8:54 ` Eli Zaretskii
2014-01-24 10:09 ` Will Newton
2014-01-24 10:28 ` Eli Zaretskii
2014-01-24 10:35 ` Will Newton
2014-01-24 10:48 ` Eli Zaretskii
2014-01-24 10:58 ` Joel Brobecker
2014-01-24 11:11 ` Eli Zaretskii
[not found] ` <20140124113014.GN4762@adacore.com>
2014-01-24 11:38 ` Joel Brobecker
2014-01-24 11:39 ` Eli Zaretskii
2014-01-24 11:55 ` Joel Brobecker
2014-01-24 14:27 ` Eli Zaretskii
2014-01-24 14:45 ` H.J. Lu
2014-01-24 15:44 ` Eli Zaretskii
2014-01-24 15:49 ` H.J. Lu
2014-01-24 16:02 ` Eli Zaretskii
2014-01-24 16:05 ` H.J. Lu
2014-01-24 16:18 ` Andreas Schwab
2014-01-24 8:07 ` Doug Evans
2014-01-24 8:38 ` Eli Zaretskii
2014-01-22 16:07 ` Tom Tromey
2014-01-23 5:58 ` Joel Brobecker
2014-01-23 15:35 ` Tom Tromey
2014-01-24 2:18 ` Joel Brobecker
2014-01-24 3:06 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140122073709.GE4762@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox