From: Eli Zaretskii <eliz@gnu.org>
To: Doug Evans <dje@google.com>
Cc: anton@samba.org, gdb-patches@sourceware.org
Subject: Re: [PATCH] TUI: Fix buffer overflow in tui_expand_tabs
Date: Sat, 21 Mar 2015 08:53:00 -0000 [thread overview]
Message-ID: <83wq2au3yf.fsf@gnu.org> (raw)
In-Reply-To: <21772.18854.130306.303139@ruffy2.mtv.corp.google.com>
> From: Doug Evans <dje@google.com>
> Date: Fri, 20 Mar 2015 09:24:06 -0700
> Cc: anton@samba.org,
> gdb-patches@sourceware.org
>
> Nit. To my eyes the following would be more readable.
>
> - int n_adjust;
> + int nc, n_adjust;
> const char *s;
> char *ret, *q;
>
> /* 1. How many additional characters do we need? */
> - for (n_adjust = 0, s = string; s; )
> + for (nc = col, n_adjust = 0, s = string; s; )
Thanks, pushed with that change (master and gdb-7.9-branch).
prev parent reply other threads:[~2015-03-21 8:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 23:30 Anton Blanchard
2015-03-19 21:44 ` Anton Blanchard
2015-03-19 22:58 ` Doug Evans
2015-03-20 8:03 ` Eli Zaretskii
2015-03-20 16:24 ` Doug Evans
2015-03-21 8:53 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83wq2au3yf.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=anton@samba.org \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox