From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-121024-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 129379 invoked by alias); 21 Mar 2015 08:53:25 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 129365 invoked by uid 89); 21 Mar 2015 08:53:24 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout22.012.net.il
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 21 Mar 2015 08:53:17 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NLK00J000FLLR00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Sat, 21 Mar 2015 10:53:12 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NLK00J7T0OOKC30@a-mtaout22.012.net.il>; Sat, 21 Mar 2015 10:53:12 +0200 (IST)
Date: Sat, 21 Mar 2015 08:53:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH] TUI: Fix buffer overflow in tui_expand_tabs
In-reply-to: <21772.18854.130306.303139@ruffy2.mtv.corp.google.com>
To: Doug Evans <dje@google.com>
Cc: anton@samba.org, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83wq2au3yf.fsf@gnu.org>
References: <20150317103009.538f2b3d@kryten> <CADPb22RopLQRqa-Us4nvK5WU_usSUUm-db61JrYz73FJ4gC73A@mail.gmail.com> <838uesw0xp.fsf@gnu.org> <21772.18854.130306.303139@ruffy2.mtv.corp.google.com>
X-IsSubscribed: yes
X-SW-Source: 2015-03/txt/msg00688.txt.bz2

> From: Doug Evans <dje@google.com>
> Date: Fri, 20 Mar 2015 09:24:06 -0700
> Cc: anton@samba.org,
>     gdb-patches@sourceware.org
> 
> Nit.  To my eyes the following would be more readable.
> 
> -  int n_adjust;
> +  int nc, n_adjust;
>    const char *s;
>    char *ret, *q;
>  
>    /* 1. How many additional characters do we need?  */
> -  for (n_adjust = 0, s = string; s; )
> +  for (nc = col, n_adjust = 0, s = string; s; )

Thanks, pushed with that change (master and gdb-7.9-branch).