Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [MI] core awareness
Date: Fri, 18 Dec 2009 11:41:00 -0000	[thread overview]
Message-ID: <83tyvo5x0s.fsf@gnu.org> (raw)
In-Reply-To: <200912162352.38585.vladimir@codesourcery.com>

> From: Vladimir Prus <vladimir@codesourcery.com>
> Date: Wed, 16 Dec 2009 23:52:38 +0300
> 
> This is mostly MI change, but includes some remote protocol tweaks,
> and documentation. I'd appreciate review of those parts.

Thanks, see below for the documentation review.

> -several threads in the list.
> +several threads in the list.  The @var{core} field reports on which
> +processor core the stop event has happened.

Suggest to rephrase slightly:

  The @var{core} field reports the processor core on which the stop
  event has happened.

> +@item id
> +The numeric id assigned to the thread by @value{GDBN}. This field is
> +always present.                                      ^^

Two spaces, please.

> +Lists thread groups (@pxref{Thread groups}). When a single thread
> +group is passed as the argument, lists the children specified one.

Something is missing in the last sentence ("children of the specified
one"?).

> +are passed, the output always have a @samp{groups} result. The format
                                 ^^^^
"has"

> +thread.  It may be present 

Pedro already noticed this incomplete sentence.

> +@value{GDBN} gdb requests, using the @samp{qXfer:threads:read}
                ^^^
Remove the "gdb" part.

> +package (@pxref{qXfer threads read}) and XML document with the
> +format described below.

Sounds like an incomplete sentence (GDB requests what?).

Thanks.


  parent reply	other threads:[~2009-12-18 11:41 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-16 20:53 Vladimir Prus
2009-12-17 15:31 ` Pedro Alves
2009-12-18 11:41 ` Eli Zaretskii [this message]
2009-12-17 15:33 Pedro Alves
2009-12-21 14:48 ` Vladimir Prus
2009-12-31 11:51   ` Pedro Alves
2010-01-04 15:11     ` Vladimir Prus
2010-01-08 20:30       ` Pedro Alves
2010-01-09 12:41         ` Vladimir Prus
2010-01-09 13:48           ` Eli Zaretskii
2010-01-11 14:17           ` Pedro Alves
2010-01-11 21:01             ` Vladimir Prus
2010-01-11 21:22               ` Pedro Alves
2010-01-12 21:44                 ` Vladimir Prus
2010-01-12 22:56                   ` Doug Evans
2010-01-12 23:08                     ` Doug Evans
2010-01-13  5:21                     ` Vladimir Prus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83tyvo5x0s.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox