From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-68951-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 19985 invoked by alias); 18 Dec 2009 11:41:24 -0000
Received: (qmail 19977 invoked by uid 22791); 18 Dec 2009 11:41:23 -0000
X-SWARE-Spam-Status: No, hits=-0.0 required=5.0 	tests=AWL,BAYES_00,RCVD_IN_JMF_BL,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 18 Dec 2009 11:41:12 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0KUU00100I38IF00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Fri, 18 Dec 2009 13:40:06 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.70.160.137]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KUU00ITEJ2O6YO0@a-mtaout22.012.net.il>; Fri, 18 Dec 2009 13:40:01 +0200 (IST)
Date: Fri, 18 Dec 2009 11:41:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [MI] core awareness
In-reply-to: <200912162352.38585.vladimir@codesourcery.com>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83tyvo5x0s.fsf@gnu.org>
References: <200912162352.38585.vladimir@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-12/txt/msg00249.txt.bz2

> From: Vladimir Prus <vladimir@codesourcery.com>
> Date: Wed, 16 Dec 2009 23:52:38 +0300
> 
> This is mostly MI change, but includes some remote protocol tweaks,
> and documentation. I'd appreciate review of those parts.

Thanks, see below for the documentation review.

> -several threads in the list.
> +several threads in the list.  The @var{core} field reports on which
> +processor core the stop event has happened.

Suggest to rephrase slightly:

  The @var{core} field reports the processor core on which the stop
  event has happened.

> +@item id
> +The numeric id assigned to the thread by @value{GDBN}. This field is
> +always present.                                      ^^

Two spaces, please.

> +Lists thread groups (@pxref{Thread groups}). When a single thread
> +group is passed as the argument, lists the children specified one.

Something is missing in the last sentence ("children of the specified
one"?).

> +are passed, the output always have a @samp{groups} result. The format
                                 ^^^^
"has"

> +thread.  It may be present 

Pedro already noticed this incomplete sentence.

> +@value{GDBN} gdb requests, using the @samp{qXfer:threads:read}
                ^^^
Remove the "gdb" part.

> +package (@pxref{qXfer threads read}) and XML document with the
> +format described below.

Sounds like an incomplete sentence (GDB requests what?).

Thanks.