From: Eli Zaretskii <eliz@gnu.org>
To: Aaron Gamble <agamble@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] info threads sort by name and name regex matching
Date: Wed, 22 Aug 2012 17:15:00 -0000 [thread overview]
Message-ID: <83txvualx8.fsf@gnu.org> (raw)
In-Reply-To: <CAHX8C+KCFAa0=Cgh1hfZuTp_QqQtmq4ASKRKoktpPue1QQ-Heg@mail.gmail.com>
> Date: Tue, 21 Aug 2012 14:18:42 -0700
> From: Aaron Gamble <agamble@google.com>
>
> Here is a patch for adding sorting by name in 'info threads' and regex
> pattern matching of thread names for filtering threads.
Thanks.
> Regex matching is specified by doing 'info threads r<regex>'. This is
> not ambiguous with previous behavior where parameters to info threads
> were only numbers. (spaces between 'r' and <regex> are ignored)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This should be documented in the manual.
> +@item info threads @r{[}@var{id}@dots{}@b{|}r<@var{regex}>@r{]}
No need for <...> around "regex", the @var markup does the equivalent
already.
> +Display a summary of all threads currently in your program. Optional
> +argument for specifying threads is either @code{r} followed by a regular
> +expression or @var{id}@dots{} one or more numeric thread ids separated by
^^^
Something's missing here, perhaps "for" or an em-dash "---".
> +spaces. The list of threads is sorted alphabetically by thread name.
^^
Two spaces between sentences, please.
The documentation part is OK with these changes.
next prev parent reply other threads:[~2012-08-22 17:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-21 21:19 Aaron Gamble
2012-08-22 10:06 ` Abid, Hafiz
2012-08-22 17:15 ` Eli Zaretskii [this message]
2012-08-22 18:52 ` Tom Tromey
2012-08-22 22:37 ` Aaron Gamble
2012-08-22 23:30 ` Sergio Durigan Junior
2012-08-23 16:00 ` Tom Tromey
2012-08-24 1:09 ` Aaron Gamble
2012-08-24 17:58 ` Tom Tromey
2012-08-24 22:23 ` Aaron Gamble
2012-08-24 22:32 ` Sergio Durigan Junior
2012-08-24 23:21 ` Aaron Gamble
2012-08-24 23:28 ` Aaron Gamble
2012-08-25 3:12 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83txvualx8.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=agamble@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox