From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-93991-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 6779 invoked by alias); 22 Aug 2012 17:15:17 -0000
Received: (qmail 6755 invoked by uid 22791); 22 Aug 2012 17:15:14 -0000
X-SWARE-Spam-Status: No, hits=-4.1 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,RCVD_IN_NIX_SPAM,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 22 Aug 2012 17:14:56 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0M9600A002JIUS00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Wed, 22 Aug 2012 20:14:36 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M9600AB92KCUM00@a-mtaout22.012.net.il>; Wed, 22 Aug 2012 20:14:36 +0300 (IDT)
Date: Wed, 22 Aug 2012 17:15:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [patch] info threads sort by name and name regex matching
In-reply-to: <CAHX8C+KCFAa0=Cgh1hfZuTp_QqQtmq4ASKRKoktpPue1QQ-Heg@mail.gmail.com>
To: Aaron Gamble <agamble@google.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83txvualx8.fsf@gnu.org>
References: <CAHX8C+KCFAa0=Cgh1hfZuTp_QqQtmq4ASKRKoktpPue1QQ-Heg@mail.gmail.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-08/txt/msg00620.txt.bz2

> Date: Tue, 21 Aug 2012 14:18:42 -0700
> From: Aaron Gamble <agamble@google.com>
> 
> Here is a patch for adding sorting by name in 'info threads' and regex
> pattern matching of thread names for filtering threads.

Thanks.

> Regex matching is specified by doing 'info threads r<regex>'. This is
> not ambiguous with previous behavior where parameters to info threads
> were only numbers. (spaces between 'r' and <regex> are ignored)
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This should be documented in the manual.

> +@item info threads @r{[}@var{id}@dots{}@b{|}r<@var{regex}>@r{]}

No need for <...> around "regex", the @var markup does the equivalent
already.

> +Display a summary of all threads currently in your program.  Optional
> +argument for specifying threads is either @code{r} followed by a regular
> +expression or @var{id}@dots{} one or more numeric thread ids separated by
                               ^^^
Something's missing here, perhaps "for" or an em-dash "---".

> +spaces. The list of threads is sorted alphabetically by thread name.
         ^^
Two spaces between sentences, please.

The documentation part is OK with these changes.