Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Philippe Waroquiers <philippe.waroquiers@skynet.be>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA 2/4] Implement | (pipe) command.
Date: Mon, 22 Apr 2019 11:08:00 -0000	[thread overview]
Message-ID: <83tveq70w8.fsf@gnu.org> (raw)
In-Reply-To: <1555929000.6208.20.camel@skynet.be> (message from Philippe	Waroquiers on Mon, 22 Apr 2019 12:30:00 +0200)

> From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
> Cc: gdb-patches@sourceware.org
> Date: Mon, 22 Apr 2019 12:30:00 +0200
> 
> Currently, on MingW, the above macros (WIFEXITED, WIFSIGNALED, ...)
> are not defined.

I think gdb_wait.h does define them for MinGW, it's just that those
definitions are currently unused anywhere that is compiled into the
MinGW build.

> So, the idea is to have gdb_wait.h defining them on MingW,
> with something like:
> 
> #ifndef	WIFEXITED
> #if defined (__MINGW32__)
> #define WIFEXITED(stat_val)   (((stat_val) & 0xC0000000) == 0)
> #else
> #define WIFEXITED(w)	(((w)&0377) == 0)
> #endif
> #endif
> 
> Then in windows-nat.c, implement windows_status_to_termsig
> that searches in xlate for stat_val & ~0xC0000000 to give
> the equivalent signal.
> 
> Does the above look reasonable ?

Yes, thanks.


  reply	other threads:[~2019-04-22 11:08 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-20 21:22 [RFA 0/4] " Philippe Waroquiers
2019-04-20 21:22 ` [RFA 2/4] " Philippe Waroquiers
2019-04-21  5:19   ` Eli Zaretskii
2019-04-21  9:40     ` Philippe Waroquiers
2019-04-21 10:18       ` Eli Zaretskii
2019-04-22 10:30         ` Philippe Waroquiers
2019-04-22 11:08           ` Eli Zaretskii [this message]
2019-04-22 13:15             ` Philippe Waroquiers
2019-04-22 13:21               ` Eli Zaretskii
2019-04-24 20:50   ` Tom Tromey
2019-04-25  5:58     ` Eli Zaretskii
2019-04-20 21:22 ` [RFA 3/4] Test the " Philippe Waroquiers
2019-04-24 20:52   ` Tom Tromey
2019-04-20 21:22 ` [RFA 4/4] NEWS and documentation for " Philippe Waroquiers
2019-04-21  5:22   ` Eli Zaretskii
2019-04-20 21:22 ` [RFA 1/4] Add previous_saved_command_line to allow a command to repeat a previous command Philippe Waroquiers
2019-04-24 20:51   ` Tom Tromey
2019-04-22 20:45 ` [RFA 0/4] Implement | (pipe) command Abhijit Halder
2019-04-22 21:14   ` Philippe Waroquiers
2019-04-24 20:53   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83tveq70w8.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=philippe.waroquiers@skynet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox