From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 123642 invoked by alias); 22 Apr 2019 11:08:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 123634 invoked by uid 89); 22 Apr 2019 11:08:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=HContent-type:plain, HContent-type:text, HContent-type:charset, Currently X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 22 Apr 2019 11:08:55 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38952) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIWoe-0005K7-4e; Mon, 22 Apr 2019 07:08:52 -0400 Received: from [176.228.60.248] (port=3237 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hIWoa-0000My-CR; Mon, 22 Apr 2019 07:08:50 -0400 Date: Mon, 22 Apr 2019 11:08:00 -0000 Message-Id: <83tveq70w8.fsf@gnu.org> From: Eli Zaretskii To: Philippe Waroquiers CC: gdb-patches@sourceware.org In-reply-to: <1555929000.6208.20.camel@skynet.be> (message from Philippe Waroquiers on Mon, 22 Apr 2019 12:30:00 +0200) Subject: Re: [RFA 2/4] Implement | (pipe) command. References: <20190420212153.30934-1-philippe.waroquiers@skynet.be> <20190420212153.30934-3-philippe.waroquiers@skynet.be> <83r29w9bpw.fsf@gnu.org> <1555839622.6208.17.camel@skynet.be> <838sw3acgz.fsf@gnu.org> <1555929000.6208.20.camel@skynet.be> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-04/txt/msg00414.txt.bz2 > From: Philippe Waroquiers > Cc: gdb-patches@sourceware.org > Date: Mon, 22 Apr 2019 12:30:00 +0200 > > Currently, on MingW, the above macros (WIFEXITED, WIFSIGNALED, ...) > are not defined. I think gdb_wait.h does define them for MinGW, it's just that those definitions are currently unused anywhere that is compiled into the MinGW build. > So, the idea is to have gdb_wait.h defining them on MingW, > with something like: > > #ifndef WIFEXITED > #if defined (__MINGW32__) > #define WIFEXITED(stat_val)   (((stat_val) & 0xC0000000) == 0) > #else > #define WIFEXITED(w) (((w)&0377) == 0) > #endif > #endif > > Then in windows-nat.c, implement windows_status_to_termsig > that searches in xlate for stat_val & ~0xC0000000 to give > the equivalent signal. > > Does the above look reasonable ? Yes, thanks.