From: Eli Zaretskii <eliz@gnu.org>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org, tromey@redhat.com
Subject: Re: [patch] make info regression on --with-system-readline
Date: Sat, 01 Jan 2011 11:26:00 -0000 [thread overview]
Message-ID: <83sjxcq2v8.fsf@gnu.org> (raw)
In-Reply-To: <20110101111629.GA21199@host1.dyn.jankratochvil.net>
> Date: Sat, 1 Jan 2011 12:16:29 +0100
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> Cc: gdb-patches@sourceware.org, tromey@redhat.com
>
> On Sat, 01 Jan 2011 11:02:02 +0100, Eli Zaretskii wrote:
> > "make distclean" _should_ be reliable, since its main raison d'etre is
> > to allow a clean build after re-configuration. So maybe we should fix
> > that instead (e.g., it doesn't currently remove GDBvn.texi).
>
> If "make distclean" should clean it then it also should not be distributed.
Yes, and I already agreed to that, albeit without saying that
explicitly ;-)
> And we are back at the point GDB currently cannot do easily `make dist'.
What is "make dist"? I see no such target in Makefile.in. Do I need
more coffee? ;-)
> > > But even if you do just first configure it is now broken in GDB as the files
> > > get inappropriately distributed.
> >
> > Sorry, I don't follow. Can you describe the scenario in more detail?
>
> rm -rf gdb-7.2.50.20101231; tar xjf gdb-7.2.50.20101231.tar.bz2; cd gdb-7.2.50.20101231; patch -p1 <THE-FIRST-PATCH-POSTED; mkdir b; cd b; CFLAGS= ../configure --with-system-readline; make; rm gdb/doc/gdb.info; make -C gdb/doc gdb.info
> ../../../gdb/doc/gdb.texinfo:30521: @include `rluser.texi': No such file or directory.
> ../../../gdb/doc/gdb.texinfo:30521: @include `inc-hist.texinfo': No such file or directory.
>
> Both exist:
> ./gdb-7.2.50.20101231/gdb/doc/GDBvn.texi
> ./gdb-7.2.50.20101231/b/gdb/doc/GDBvn.texi
Okay, but what I really meant is what's that part about "the files get
inappropriately distributed"? I guess you just meant to say the same
thing IOW, namely that a wrong GDBvn.texi gets picked up by makeinfo,
is that right?
> > I prefer to do with GDBvn.texi what many projects do with config.h:
> > regenerate it on a temporary file, then use move-if-change to move it
> > into the real file. Would that resolve your problem? It certainly
> > resolves mine.
>
> OK, going to post it.
Thanks.
next prev parent reply other threads:[~2011-01-01 11:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-01 1:13 Jan Kratochvil
2011-01-01 8:08 ` [patch] make info out-of-src-tree " Jan Kratochvil
2011-01-01 9:34 ` Eli Zaretskii
2011-01-01 10:51 ` Jan Kratochvil
2011-01-01 9:23 ` [patch] make info " Eli Zaretskii
2011-01-01 9:38 ` Jan Kratochvil
2011-01-01 10:00 ` Eli Zaretskii
2011-01-01 11:16 ` Jan Kratochvil
2011-01-01 11:26 ` Eli Zaretskii [this message]
2011-01-01 11:43 ` Jan Kratochvil
2011-01-01 12:20 ` Eli Zaretskii
2011-01-01 12:30 ` Jan Kratochvil
2011-01-01 15:36 ` Eli Zaretskii
2011-01-01 16:32 ` Jan Kratochvil
2011-01-01 16:44 ` Eli Zaretskii
2011-01-03 12:21 ` [new patch] " Jan Kratochvil
2011-01-03 12:57 ` Eli Zaretskii
2011-01-03 13:02 ` Jan Kratochvil
2011-01-04 5:43 ` Jan Kratochvil
2011-01-04 6:31 ` Eli Zaretskii
2011-01-01 11:40 ` [patch] " Jan Kratochvil
2011-01-01 12:15 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83sjxcq2v8.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox