From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13473 invoked by alias); 1 Jan 2011 11:26:59 -0000 Received: (qmail 13464 invoked by uid 22791); 1 Jan 2011 11:26:59 -0000 X-SWARE-Spam-Status: No, hits=-0.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL,TW_XJ X-Spam-Check-By: sourceware.org Received: from mtaout21.012.net.il (HELO mtaout21.012.net.il) (80.179.55.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 01 Jan 2011 11:26:53 +0000 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0LEC00600D0MUB00@a-mtaout21.012.net.il> for gdb-patches@sourceware.org; Sat, 01 Jan 2011 13:26:51 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.124.219.104]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LEC006HED4QJW80@a-mtaout21.012.net.il>; Sat, 01 Jan 2011 13:26:51 +0200 (IST) Date: Sat, 01 Jan 2011 11:26:00 -0000 From: Eli Zaretskii Subject: Re: [patch] make info regression on --with-system-readline In-reply-to: <20110101111629.GA21199@host1.dyn.jankratochvil.net> To: Jan Kratochvil Cc: gdb-patches@sourceware.org, tromey@redhat.com Reply-to: Eli Zaretskii Message-id: <83sjxcq2v8.fsf@gnu.org> References: <20110101011319.GA27139@host1.dyn.jankratochvil.net> <8339pdq8la.fsf@gnu.org> <20110101093815.GA24535@host1.dyn.jankratochvil.net> <83y675osbp.fsf@gnu.org> <20110101111629.GA21199@host1.dyn.jankratochvil.net> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00010.txt.bz2 > Date: Sat, 1 Jan 2011 12:16:29 +0100 > From: Jan Kratochvil > Cc: gdb-patches@sourceware.org, tromey@redhat.com > > On Sat, 01 Jan 2011 11:02:02 +0100, Eli Zaretskii wrote: > > "make distclean" _should_ be reliable, since its main raison d'etre is > > to allow a clean build after re-configuration. So maybe we should fix > > that instead (e.g., it doesn't currently remove GDBvn.texi). > > If "make distclean" should clean it then it also should not be distributed. Yes, and I already agreed to that, albeit without saying that explicitly ;-) > And we are back at the point GDB currently cannot do easily `make dist'. What is "make dist"? I see no such target in Makefile.in. Do I need more coffee? ;-) > > > But even if you do just first configure it is now broken in GDB as the files > > > get inappropriately distributed. > > > > Sorry, I don't follow. Can you describe the scenario in more detail? > > rm -rf gdb-7.2.50.20101231; tar xjf gdb-7.2.50.20101231.tar.bz2; cd gdb-7.2.50.20101231; patch -p1 ../../../gdb/doc/gdb.texinfo:30521: @include `rluser.texi': No such file or directory. > ../../../gdb/doc/gdb.texinfo:30521: @include `inc-hist.texinfo': No such file or directory. > > Both exist: > ./gdb-7.2.50.20101231/gdb/doc/GDBvn.texi > ./gdb-7.2.50.20101231/b/gdb/doc/GDBvn.texi Okay, but what I really meant is what's that part about "the files get inappropriately distributed"? I guess you just meant to say the same thing IOW, namely that a wrong GDBvn.texi gets picked up by makeinfo, is that right? > > I prefer to do with GDBvn.texi what many projects do with config.h: > > regenerate it on a temporary file, then use move-if-change to move it > > into the real file. Would that resolve your problem? It certainly > > resolves mine. > > OK, going to post it. Thanks.