Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [doc RFA] "New" command "!"
Date: Fri, 11 Nov 2011 19:31:00 -0000	[thread overview]
Message-ID: <83sjlufofh.fsf@gnu.org> (raw)
In-Reply-To: <CADPb22Ss6L=ZWw09_6UfcsJ4peGscXErCJDP5vLRD6Kd9s7pXg@mail.gmail.com>

> Date: Fri, 11 Nov 2011 09:18:55 -0800
> From: Doug Evans <dje@google.com>
> 
> --- NEWS	2 Nov 2011 23:44:19 -0000	1.464
> +++ NEWS	11 Nov 2011 15:46:51 -0000
> @@ -104,6 +104,12 @@
>    at the time the function got called.  Entry values are available only since
>    gcc version 4.7.
>  
> +* New commands
> +
> +!SHELL COMMAND
> +  "!" is now an alias of the "shell" command.
> +  Note that no space is needed between "!" and SHELL COMMAND.

This is okay.

>  @item shell @var{command string}
> +@itemx ! @var{command string}

There should be no space between `!' and the rest, right?

Also, I'd suggest to tell here explicitly what you told in NEWS:

  Note that no space is needed between @code{!} and @var{command string}.

Btw, it is customary not to have spaces in @var.  Use hyphens or
underscores instead.  (Yes, I know it was that way before you added
the alias.)

Thanks.


  reply	other threads:[~2011-11-11 19:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-08  9:38 [RFC] " Doug Evans
2011-11-08 14:56 ` Tom Tromey
2011-11-08 15:36 ` Hui Zhu
2011-11-08 15:44 ` Tom Tromey
2011-11-08 15:51 ` Pedro Alves
2011-11-08 17:26 ` Doug Evans
2011-11-11 17:19 ` [doc RFA] " Doug Evans
2011-11-11 19:31   ` Eli Zaretskii [this message]
2011-11-15 17:00     ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83sjlufofh.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox