From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-85150-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 21387 invoked by alias); 11 Nov 2011 19:31:39 -0000
Received: (qmail 21379 invoked by uid 22791); 11 Nov 2011 19:31:38 -0000
X-SWARE-Spam-Status: No, hits=-0.9 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout21.012.net.il (HELO mtaout21.012.net.il) (80.179.55.169)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 Nov 2011 19:31:26 +0000
Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0LUI00E00GS2XG00@a-mtaout21.012.net.il> for gdb-patches@sourceware.org; Fri, 11 Nov 2011 21:31:19 +0200 (IST)
Received: from HOME-C4E4A596F7 ([77.126.231.130]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LUI00EIFGW6WU30@a-mtaout21.012.net.il>; Fri, 11 Nov 2011 21:31:19 +0200 (IST)
Date: Fri, 11 Nov 2011 19:31:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [doc RFA] "New" command "!"
In-reply-to: <CADPb22Ss6L=ZWw09_6UfcsJ4peGscXErCJDP5vLRD6Kd9s7pXg@mail.gmail.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83sjlufofh.fsf@gnu.org>
References: <20111108093759.279E3246194@ruffy.mtv.corp.google.com> <CADPb22Ss6L=ZWw09_6UfcsJ4peGscXErCJDP5vLRD6Kd9s7pXg@mail.gmail.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-11/txt/msg00327.txt.bz2

> Date: Fri, 11 Nov 2011 09:18:55 -0800
> From: Doug Evans <dje@google.com>
> 
> --- NEWS	2 Nov 2011 23:44:19 -0000	1.464
> +++ NEWS	11 Nov 2011 15:46:51 -0000
> @@ -104,6 +104,12 @@
>    at the time the function got called.  Entry values are available only since
>    gcc version 4.7.
>  
> +* New commands
> +
> +!SHELL COMMAND
> +  "!" is now an alias of the "shell" command.
> +  Note that no space is needed between "!" and SHELL COMMAND.

This is okay.

>  @item shell @var{command string}
> +@itemx ! @var{command string}

There should be no space between `!' and the rest, right?

Also, I'd suggest to tell here explicitly what you told in NEWS:

  Note that no space is needed between @code{!} and @var{command string}.

Btw, it is customary not to have spaces in @var.  Use hyphens or
underscores instead.  (Yes, I know it was that way before you added
the alias.)

Thanks.