From: Eli Zaretskii <eliz@gnu.org>
To: Peter Linss <peter@elemental.software>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix usage of to_string() for pretty-printers with children
Date: Thu, 25 May 2017 14:59:00 -0000 [thread overview]
Message-ID: <83shjtkmo8.fsf@gnu.org> (raw)
In-Reply-To: <DA4CEF9D-0714-4EA8-A08A-A3F02B923269@elemental.software> (message from Peter Linss on Wed, 24 May 2017 19:33:41 -0700)
> From: Peter Linss <peter@elemental.software>
> Date: Wed, 24 May 2017 19:33:41 -0700
>
> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index 9fb70f6d2a..05e5b868ed 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -29444,8 +29444,9 @@ reliable for a dynamic varobj. Instead, you must examine the
>
> @item value
> The varobj's scalar value. For a varobj whose type is some sort of
> -aggregate (e.g., a @code{struct}), or for a dynamic varobj, this value
> -will not be interesting.
> +aggregate (e.g., a @code{struct}) this value will not be interesting.
^
Please add back the comma removed here.
The documentation part is approved with this gotcha fixed.
Thanks.
next prev parent reply other threads:[~2017-05-25 14:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-25 2:33 Peter Linss
2017-05-25 10:06 ` Phil Muldoon
2017-05-25 17:42 ` Peter Linss
2017-06-14 2:36 ` Peter Linss
2017-05-25 14:59 ` Eli Zaretskii [this message]
2017-05-25 17:51 ` Peter Linss
2017-05-25 18:13 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83shjtkmo8.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=peter@elemental.software \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox