From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32719 invoked by alias); 25 May 2017 14:59:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32693 invoked by uid 89); 25 May 2017 14:59:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 25 May 2017 14:59:08 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dDuEF-0001PT-Ja for gdb-patches@sourceware.org; Thu, 25 May 2017 10:59:10 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44129) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dDuEF-0001PJ-GY; Thu, 25 May 2017 10:59:07 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2600 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dDuEE-0005GH-RD; Thu, 25 May 2017 10:59:07 -0400 Date: Thu, 25 May 2017 14:59:00 -0000 Message-Id: <83shjtkmo8.fsf@gnu.org> From: Eli Zaretskii To: Peter Linss CC: gdb-patches@sourceware.org In-reply-to: (message from Peter Linss on Wed, 24 May 2017 19:33:41 -0700) Subject: Re: [PATCH] Fix usage of to_string() for pretty-printers with children Reply-to: Eli Zaretskii References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00545.txt.bz2 > From: Peter Linss > Date: Wed, 24 May 2017 19:33:41 -0700 > > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > index 9fb70f6d2a..05e5b868ed 100644 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -29444,8 +29444,9 @@ reliable for a dynamic varobj. Instead, you must examine the > > @item value > The varobj's scalar value. For a varobj whose type is some sort of > -aggregate (e.g., a @code{struct}), or for a dynamic varobj, this value > -will not be interesting. > +aggregate (e.g., a @code{struct}) this value will not be interesting. ^ Please add back the comma removed here. The documentation part is approved with this gotcha fixed. Thanks.