From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Handle \r\n in gdbreplay
Date: Thu, 21 Feb 2019 15:14:00 -0000 [thread overview]
Message-ID: <83sgwhfa1o.fsf@gnu.org> (raw)
In-Reply-To: <20190221140513.29508-1-tromey@adacore.com> (message from Tom Tromey on Thu, 21 Feb 2019 07:05:13 -0700)
> From: Tom Tromey <tromey@adacore.com>
> Cc: Tom Tromey <tromey@adacore.com>
> Date: Thu, 21 Feb 2019 07:05:13 -0700
>
> I tried gdbreplay yesterday, but the remotelogfile I received was made
> on Windows, so the lines were terminated with \r\n rather than plain
> \n.
>
> This patch changes gdbreplay to allow \r or \r\n line termination when
> reading the log file.
I'm okay with treating \r\n as a single \n, but do we really want to
treat a single \r as if it were \n? I thought systems which used that
EOL convention are not really widespread, to say the least.
Thanks.
next prev parent reply other threads:[~2019-02-21 15:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 14:05 Tom Tromey
2019-02-21 15:14 ` Eli Zaretskii [this message]
2019-02-21 16:07 ` Tom Tromey
2019-02-21 16:12 ` Paul Koning
2019-02-27 18:49 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83sgwhfa1o.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox